Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning when files can be regenerated #266

Open
2 of 3 tasks
kirtangajjar opened this issue Dec 17, 2018 · 1 comment
Open
2 of 3 tasks

Add warning when files can be regenerated #266

kirtangajjar opened this issue Dec 17, 2018 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@kirtangajjar
Copy link
Contributor

kirtangajjar commented Dec 17, 2018

EE4 has files which can be regenerated. Example include:

  • nginx-proxy's default.conf
  • Site nginx's main.conf
  • php.ini

Each of such files should have a warning on top like ee3 had which would prevent accidental edits.

@mrrobot47
Copy link
Member

PHP config changes have been reverted post merging. As the name was custom.ini, users may have thought that this was the ini that could be customized as per need. Thus, regenerating this could lead to issues.

Hence, EasyEngine can keep on generating this custom.ini for all new sites. If there is any need or update required. A new ini file named easyengine.ini can be introduced which will have the config loss warning and new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants