Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create a trim_headers functional test #1242

Closed
delta1 opened this issue Jun 15, 2023 · 2 comments
Closed

create a trim_headers functional test #1242

delta1 opened this issue Jun 15, 2023 · 2 comments

Comments

@delta1
Copy link
Member

delta1 commented Jun 15, 2023 •
edited
Loading

we really need a functional test that exercises the trim_headers mode (#1190)

this would be useful to make sure that it continues to work after merging changes from upstream, or any other fixes/features
@psgreco
Copy link
Contributor

psgreco commented Jun 15, 2023

Some things come to mind that would be needed for this:

1. 2 nodes, 1 for generation and 1 for testing (trim_header nodes don't offer blocks)
2. signed blocks (not -generate)
3. short epoch times, to make it easier to trigger
4. start in non-dynafed mode (to check blocks with Proof)
5. transition into dynafed after a few blocks to have both types of blocks trimmed
6. test both real time cleanup and IBD
7. test getblock and getblockheader rpcs
8. check interaction with pruning (I don't think this is working right now)

@delta1 delta1 mentioned this issue Jul 18, 2023
Closed
@delta1
Copy link
Member Author

delta1 commented Sep 17, 2024

was included in #1270

@delta1 delta1 closed this as completed Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: add trim_headers functional test delta1/elements
2 participants
@delta1 @psgreco