From 4bf2bbc8616c9a50311058abf5ff9e7b56775400 Mon Sep 17 00:00:00 2001 From: Saibato Date: Fri, 8 Nov 2019 22:03:25 +0100 Subject: [PATCH] We state not to do 'any local DNS' if --always-use-proxy flag is set, so we should this Even if it is on startup only once ... Like @bitcoin-software indicated the expected UX should be in line with what a user expects the software will do so we should not dns if we say so with a flag that suggest that. Changelog-Fixed: We disable all dns even on startup the scan for bogus dns servers, if --always-use-proxy is set true Signed-off-by: Saibato --- connectd/connectd.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/connectd/connectd.c b/connectd/connectd.c index 4e44c49ac83e..f06d1e031e96 100644 --- a/connectd/connectd.c +++ b/connectd/connectd.c @@ -1180,9 +1180,12 @@ static struct io_plan *connect_init(struct io_conn *conn, } else daemon->proxyaddr = NULL; - if (broken_resolver(daemon)) { - status_debug("Broken DNS resolver detected, will check for " - "dummy replies"); + /* We state not to do 'any local DNS' if flag is set so we should do this */ + if (!daemon->use_proxy_always) { + if (broken_resolver(daemon)) { + status_debug("Broken DNS resolver detected, will check for " + "dummy replies"); + } } /* Figure out our addresses. */