-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the UNUSUAL warning about plugin bcli #3553
Comments
I made it an UNUSUAL because it was before a fatal error, but also because we use UNUSUAL log for some others startup things ("Bitcoin now synced", etc..). Maybe you got confused because you were used to the other UNUSUAL log lines but not this one ? :) |
I don't know,. It looks unusual to me :-) It's not a big thing of course. I created this issue as a reminder. You developers can decide to close it or keep it open. |
Perhaps So:
Choosing |
I think libplugin should be as general as possible, and requiring the socket is the special case for a plugin (a lot of the plugins from the community curated list dont send command to lightningd, for example). About the special entrypoint it means charging |
Complications exist, and will remain existent. While we strive to reduce complications, in the case where we cannot, we can at least strive to keep the complication contained. So I suggest doing something like:
Then What is happening now is that the complication leaks all the way up to the user, who is now confused with an unusual message, leading to this issue. Since this is a complication (the original |
FWIW, I am here because I saw the same message on my first lightningd run, and was curious if it is normal. :) |
The first c-lightning output a user sees is the following message:
UNUSUAL plugin-bcli: Could not connect to 'lightning-rpc': Connection refused
as kindly explained by darosior
It's the expected behavior: a new plugin (bcli) introduced in the last release needs to be initialized before we even start listening on the RPC socket, hence it fails the connect().
If it's expected behavior, c-lightning shouldn't output UNUSUAL. It got me on the wrong track when updating to version 0.8.1. This should be corrected in some way.
The text was updated successfully, but these errors were encountered: