-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gossipd should be more forgiving on routing errors #867
Labels
Comments
ZmnSCPxj
changed the title
Feature: gossipd should be more forgiving on routing errors [gossipd]
Enhancement: gossipd should be more forgiving on routing errors [gossipd]
Feb 1, 2018
cdecker
changed the title
Enhancement: gossipd should be more forgiving on routing errors [gossipd]
gossipd should be more forgiving on routing errors
Feb 1, 2018
ZmnSCPxj
added a commit
to ZmnSCPxj/lightning
that referenced
this issue
Feb 2, 2018
ZmnSCPxj
added a commit
to ZmnSCPxj/lightning
that referenced
this issue
Feb 2, 2018
ZmnSCPxj
added a commit
to ZmnSCPxj/lightning
that referenced
this issue
Feb 2, 2018
ZmnSCPxj
added a commit
to ZmnSCPxj/lightning
that referenced
this issue
Feb 3, 2018
cdecker
pushed a commit
that referenced
this issue
Feb 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, gossipd is somewhat heavy-handed in treating routing errors. Currently it simply deactivates the failing channels, which will get reactivated when we receive a
channel_update
message --- but we do not expect to getchannel_update
often, so an otherwise perfectly-fine channel might get disabled indefinitely on our routing map.One idea is to have a simple timer on how long we ban a channel on a temporary routing failure. We could add a
u64 banned_until
field to eachnode_connection
that defaults to 0. If the current time is less than or equal tobanned_until
, we do not consider that connection for routing. If we get achannel_update
we also clear this field. Then on a temporary channel failure instead of clearingactive
we simply get the current time, add say 30 seconds to it, then load the resulting time intobanned_until
.xref: #638 (comment)
The text was updated successfully, but these errors were encountered: