Fund all #1249
Fund all #1249
Conversation
lightningd/opening_control.c
Outdated
| return; | ||
| } | ||
| fc->change = 0; | ||
| } else { |
There was a problem hiding this comment.
Need to set fc->change_keyindex = 0 too, to quiet valgrind.
cli/lightning-cli.c
Outdated
| @@ -271,7 +271,9 @@ int main(int argc, char *argv[]) | |||
| add_input(&cmd, argv[i], i, argc); | |||
| tal_append_fmt(&cmd, "] }"); | |||
| } | |||
|
|
|||
| #if 0 | |||
cli/lightning-cli.c
Outdated
| @@ -341,7 +343,6 @@ int main(int argc, char *argv[]) | |||
| opt_free_table(); | |||
| return 0; | |||
| } | |||
|
|
|||
lightningd/opening_control.c
Outdated
| command_fail(cmd, "Could not parse id"); | ||
| return; | ||
| } | ||
| fc->funding_satoshi = 0; |
lightningd/opening_control.c
Outdated
| return; | ||
| } | ||
| fc->change = 0; | ||
| } else { |
lightningd/opening_control.c
Outdated
| } | ||
| fc->change = 0; | ||
| } else { | ||
| fc->utxomap = build_utxos(fc, cmd->ld, fc->funding_satoshi, |
There was a problem hiding this comment.
Insufficient indentation.
|
Please don't do merge commits, they tend to mess up the history. |
|
Excellent work, this is starting to look very promising. In its current state I'd squash the PR into a single commit, but if you find it better to organize it into multiple commits feel free to split it according to those lines and Other than the random naming changes I'm happy with the PR as it currently is. |
|
I see now what that merge did to the history. What's the proper git way for me to squash this branch? Do I squash all the merged commits too? Also, I'll back out the naming changes, that was me starting to try and unify |
|
@wythe no worries, I'll just squash the PR, since the only reasonable separation I can think of is to split out the integration test, but that's also a bit artificial. |
|
Congrats @wythe to your first commit to the c-lightning repository ⚡ |
|
Great. Thanks for the help. |
This is a work in progress for #665.
I have the basic feature implemented. I want to remove redundant code and make testing more comprehensive. Also, there is a valgrind error in one of the tests.