Make gossipd more forgiving of temporary routing failures #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZmnSCPxj
force-pushed
the
temporary-ban
branch
from
8dd50fc
to
e8cb0fe
Compare
|
Rebased to fix conflict. |
rustyrussell
approved these changes
Feb 2, 2018
gossipd/routing.c
Outdated
| @@ -341,6 +343,12 @@ static void bfg_one_edge(struct node *node, size_t edgenum, double riskfactor) | |||
| } | |||
| } | |||
|
|
|||
| /* Determine if the given node_connection is routable */ | |||
| static bool nc_is_routable(const struct node_connection *nc, u64 now) | |||
There was a problem hiding this comment.
I would use time_t here; it's u64 where it matters and is self-documenting nicely.
gossipd/routing.c
Outdated
| /* Call time_now() once at the start, so that our tight loop | ||
| * does not keep calling into operating system for the | ||
| * current time */ | ||
| u64 now = time_now().ts.tv_sec; |
gossipd/routing.c
Outdated
| @@ -1041,15 +1054,17 @@ get_out_node_connection_of(struct routing_state *rstate, | |||
| */ | |||
| static void routing_failure_on_nc(struct routing_state *rstate, | |||
| enum onion_type failcode, | |||
| struct node_connection *nc) | |||
| struct node_connection *nc, | |||
| u64 now) | |||
gossipd/routing.h
Outdated
|
|
||
| /* If greater than current time, this connection should not | ||
| * be used for routing. */ | ||
| u64 unroutable_until; |
ZmnSCPxj
force-pushed
the
temporary-ban
branch
from
e8cb0fe
to
d9e4203
Compare
|
Fixed as per review. |
|
ACK d9e4203 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #867
Policy: disable failing channels for 20 seconds, or the next
channel_update.Implementation: Use a
u64 unroutable_until, a UNIX-time variable, which prevents a channel from being used for routing if less than the current time in UNIX epoch. Set this to 20+current time if routing failure reported. Set to 0 on construction orchannel_update.