Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing include of optional #1

Open
adv4ncr opened this issue Aug 2, 2024 · 2 comments
Open

Missing include of optional #1

adv4ncr opened this issue Aug 2, 2024 · 2 comments

Comments

@adv4ncr
Copy link

adv4ncr commented Aug 2, 2024

Hi Sven,
i think you missed #include <optional> in the header:

EiCOS/include/eicos.hpp

Line 3 in 87398a9

#include <Eigen/Sparse>

@adv4ncr
Copy link
Author

adv4ncr commented Aug 2, 2024

And a semicolon here in the README:
https://github.com/EmbersArc/EiCOS/blob/87398a9c4732b09c5b2524470b67ad583719423b/README.md?plain=1#L78C1-L78C15

@EmbersArc
Copy link
Owner

Hey! Indeed, newer compilers require explicit includes. Feel free to open a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@EmbersArc @adv4ncr