Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethinking how Niffler handles multiple query sources at once #406

Open
pradeeban opened this issue May 5, 2023 · 1 comment
Open

Rethinking how Niffler handles multiple query sources at once #406

pradeeban opened this issue May 5, 2023 · 1 comment

Comments

@pradeeban
Copy link
Member

Currently, we support querying multiple sources by running ColdDataRetriever twice (or more times), by changing these parameters in the system.json.

  • NifflerID: The ID of the current execution. Default is 1. You must increment the second execution to 2, so that the logs are properly stored in niffler1.log and niffler2.log.

  • MaxNifflerProcesses: How many Niffler processes can run in parallel. Make sure each execution has its own SrcAet properly configured. Each SrcAet can run only once.

But the same Query AET can run multiple queries to multiple source AETs. So, we may rethink our approach and fix the implementation.

This will be especially useful if all the SourceAET only know and accept that one particular Niffler instance, defined by a Hostnmae, port, and AET as something like (x.x.x.x, 4242, QBNIFFLER).

@pradeeban
Copy link
Member Author

Technically, it should be possible to just run Niffler twice with the same configs except for Src AET, to get data from two different destinations.

We put checks in place to make sure Niflfler is not mistakenly run twice by two different people, getting the data mixed up.

Probably, we just need another parameter to confirm the subsequent run is intentional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant