Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transient lit mode output is strange #9

Closed
Opacitation opened this issue Apr 7, 2023 · 5 comments
Closed

Transient lit mode output is strange #9

Opacitation opened this issue Apr 7, 2023 · 5 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed todo Some task to be done in the future.

Comments

@Opacitation
Copy link

Hi! I'm interested in rendering and have been learning taichi lang for a while. I played with your renderer several days ago and I think the outputs of transient lit mode is not so correct. It looks kinda strange if you actually use it in scenes like bunny and so on. Like in bunny scene, some places are lit too early, like those colored walls.

@Enigmatisms
Copy link
Owner

Yeah... I found that, too. I checked my implementation and, well, I guess there certainly is some refactoring work to do. It seems that the duration calculation for transient_lit mode is utterly wrong. It should have been based on projecting vertices starting from the emitter directly to the camera plane. However, I am busy with some other stuffs recently, therefore might not be able to correct this. So feel free to make a PR if you correct it yourself, it would be much appreciated.

@Enigmatisms Enigmatisms self-assigned this Apr 7, 2023
@Enigmatisms Enigmatisms added bug Something isn't working help wanted Extra attention is needed todo Some task to be done in the future. labels Apr 7, 2023
@Opacitation
Copy link
Author

Thanks. I will try if I got time. Should I leave this issue unclosed?

@Enigmatisms
Copy link
Owner

It's fine to leave it be. This issue will be closed when the bug is fixed.

@Enigmatisms
Copy link
Owner

Staled issue, it won't be fixed until 1.6.0 / 1.7.0, which might be a long time. Feel free to re-open.

@Enigmatisms
Copy link
Owner

This is fixed in the lastest commit (not release).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed todo Some task to be done in the future.
Projects
None yet
Development

No branches or pull requests

2 participants