Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown: make images able to draw side by side with other images or text #112

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DeDiamondPro
Copy link
Contributor

@DeDiamondPro DeDiamondPro commented May 2, 2023

This pull request is based on #111 to prevent any possible merge conflicts with it

This pull request makes it so images can render side by side other images or text.
Code used for example:

        MarkdownComponent(
            "![](https://picsum.photos/225)![](https://picsum.photos/225)![](https://picsum.photos/225) Small images with text that wraps directly after it."
        ).constrain {
            x = CenterConstraint()
            y = 0.pixels()
            width = 800.pixels()
            height = 100.percent()
        } childOf window

Before:
image
After:
image

While I couldn't find the spec detailing that this is the way to do it, I believe it is since GitHub (and every other markdown renderer I know of) does it.
Example:

![](picsum.photos/200/100)![](picsum.photos/200/100)text

renders as:
text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant