Update preprocessor #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automaticaly generated via cleanupUnnecessaryMappings task.
Now that preprocessor supports manual method mappings with specific descriptors, we can remap all of these via mappings instead of having to use preprocessor statements. The blendEquation one should have been using GlStateManager on 1.12.2 anyway.
DJtheRedstoner
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest preprocessor has two new features which UC can make good use of:
translate(DDD)Vtotranslated(), buttranslate(FFF)Vtotranslatef()), allowing us to use extra mappings for a bunch more things which previously had to use preprocessor statements.It also gained a
cleanupUnnecessaryMappingstask which will automatically remove any mapping entries which don't do anything (be it because of point 2, or because they were broken or redundant to begin with).This also fixes
UGraphics.blendEquationinappropriately bypassingGlStateManageron 1.12.2.