Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of vegan::pca() breaks PLSDAbatch #4

Closed
gavinsimpson opened this issue Jun 23, 2024 · 1 comment
Closed

Addition of vegan::pca() breaks PLSDAbatch #4

gavinsimpson opened this issue Jun 23, 2024 · 1 comment

Comments

@gavinsimpson
Copy link

gavinsimpson commented Jun 23, 2024

Because you import the entire vegan namespace at the end of your NAMESPACE, our adding vegan::pca() breaks your package.

For example,

pca.res <- pca(X = data, ncomp = ncomp, scale = TRUE)

will now be run with vegan::pca() not the intended mixOmics::pca(). Ideally, you would change to selectively importing from the vegan namespace only those functions that you actually use. If you don't want to do that, you'll need to use the fully-qualified function name, in this case mixOmics::pca( ... ), but that will still raise a warning from R CMD check.

We are planning to release a version of vegan with these changes in August (although that may slip).

@EvaYiwenWang
Copy link
Owner

Hello Gavin,
I see the issue, will update my package soon to fix that. Many thanks!

Best regards,
Eva

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants