From a35c30f87dbf2f731bf45f43bc1a9c4d28391938 Mon Sep 17 00:00:00 2001 From: Tomasz Misiukiewicz Date: Tue, 23 Jul 2024 14:43:21 +0200 Subject: [PATCH] reduce the amount of filters, compare data without parsing to string --- src/libs/TransactionUtils.ts | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/libs/TransactionUtils.ts b/src/libs/TransactionUtils.ts index 752fadc7b2c1..4199cc510a7a 100644 --- a/src/libs/TransactionUtils.ts +++ b/src/libs/TransactionUtils.ts @@ -579,11 +579,10 @@ function hasRoute(transaction: OnyxEntry, isDistanceRequestType?: b } function getAllReportTransactions(reportID?: string, transactions?: OnyxCollection): Transaction[] { - // `reportID` from the `/CreateDistanceRequest` endpoint return's number instead of string for created `transaction`. - // For reference, https://github.com/Expensify/App/pull/26536#issuecomment-1703573277. - // We will update this in a follow-up Issue. According to this comment: https://github.com/Expensify/App/pull/26536#issuecomment-1703591019. - const nonNullableTransactions: Transaction[] = Object.values(transactions ?? allTransactions ?? {}).filter((transaction): transaction is Transaction => !!transaction); - return nonNullableTransactions.filter((transaction) => `${transaction.reportID}` === `${reportID}`); + const reportTransactions: Transaction[] = Object.values(transactions ?? allTransactions ?? {}).filter( + (transaction): transaction is Transaction => !!transaction && transaction.reportID === reportID, + ); + return reportTransactions; } function waypointHasValidAddress(waypoint: RecentWaypoint | Waypoint): boolean {