[HOLD for payment 2022-09-01] [$250] Whitespace on screen where keyboard used to be

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open any chat
2. Press on the composer (open keyboard)
3. Put the app in the background
4. Open again with the keyboard open
5. Press back immediately
6. You should see the bottom space same as the keyboard height

Expected Result:

No white space should display

Actual Result:

Whitespace on screen where keyboard used to be

Workaround:

unknown

Platform:

Where is this issue occurring?

• iOS

Version Number: 1.1.86-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Upwork URL: https://www.upwork.com/jobs/~012bd08b740a4f2ffa
Issue reported by: @roryabraham
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1659026555000119

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[roryabraham]

Not sure if we have bulletproof reproduction steps here. We should try to nail that down a bit before making this external, imo.

[roryabraham]

I've definitely seen this happen a number of times in the wild on a physical device though

[luacmartins]

Agreed! I'll try to reproduce this some time this week

[dhairyasenjaliya]

I actually have this issue thought it was some local issue so didn't report it on slack, but it seems to be a real issue

Steps to reproduce

1. Open any chat
2. Press on the composer (open keyboard)
3. Put the app in the background
4. Open again with the keyboard open
5. Press back immediately
6. You should see the bottom space same as the keyboard height

ios_keyboard_issue.mp4

[luacmartins]

Hmm I can't reproduce this on the latest main (1.1.87-8) or staging (1.1.86-5). We reverted this PR which was causing a lot of similar issues and that was deployed in v1.1.86-2. Is this still happening on v1.1.86-2 or higher (this issue mentions 1.1.86-0)?

[dhairyasenjaliya]

@luacmartins I can reproduce in latest code 1.1.87-8

[luacmartins]

@dhairyasenjaliya I tried your steps above, while I couldn't repro on dev, I did see the behavior on a physical device on staging. The one caveat is that the white space goes away after a little bit. The events are something like:

1. Open chat and focus on the compose box (keyboard will open)
2. Navigate away from chat (keyboard closes), but whitespace remains
3. Whitespace animates away after a few seconds

So something seems to be blocking the JS thread and making the UI hang. I'll apply the external label, feel free to submit a proposal!

[melvin-bot]

Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[trjExpensify]

I'm unable to attempt to reproduce this because I'm suffering some serious issues on iOS at the moment (being looked at elsewhere).

The action steps in the OP are pretty light, I'm going to update them to @dhairyasenjaliya ones from here:

1. Open any chat
2. Press on the composer (open keyboard)
3. Put the app in the background
4. Open again with the keyboard open
5. Press back immediately
6. You should see the bottom space same as the keyboard height

[trjExpensify]

Job on upwork here: https://www.upwork.com/jobs/~012bd08b740a4f2ffa

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

[melvin-bot]

Triggered auto assignment to @ctkochan22 (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[trjExpensify]

Hm, why did @ctkochan22 also get assigned here?

[melvin-bot]

📣 @dhairyasenjaliya You have been assigned to this job by @mountiny!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[trjExpensify]

Cool, @dhairyasenjaliya let me know when you've applied on Upwork!

[dhairyasenjaliya]

hm @trjExpensify can't apply links seems to private

[trjExpensify]

Interesting.. I wonder why that is. Can you try this link? https://www.upwork.com/jobs/~012bd08b740a4f2ffa

[dhairyasenjaliya]

@trjExpensify still I can't apply
Only invited users can find, view and apply to the job

[trjExpensify]

Ah yeah okay, so that setting was invited users only. Changed it and it should be good now.

[dhairyasenjaliya]

applied thank you :)
@trjExpensify

[trjExpensify]

👋 Where are we at on the PR. Have we completed the retests?

[luacmartins]

No updates on the retests. @mountiny asked for one not too long ago.

[rushatgabhane]

All platforms test really well! We're back on track.

Gotta do some small cleanups from main branch

[rushatgabhane]

PR is on staging

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.89-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• IOS/Android - Payments - Making payment method default will have keyboard overlapping password prompt  #10162

If no regressions arise, payment will be issued on 2022-09-01. 🎊

[dhairyasenjaliya]

hello @trjExpensify can we close this one as this is in production

[trjExpensify]

Yep, paid @dhairyasenjaliya.
@rushatgabhane, I need you to accept the offer for C+.

[trjExpensify]

Kewl, paid @rushatgabhane now as well. Closing it out!