Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2022-09-08 #10883

Closed
25 tasks done
OSBotify opened this issue Sep 8, 2022 · 10 comments
Closed
25 tasks done

Deploy Checklist: New Expensify 2022-09-08 #10883

OSBotify opened this issue Sep 8, 2022 · 10 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Sep 8, 2022

Release Version: 1.1.98-1
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

@Julesssss Julesssss self-assigned this Sep 8, 2022
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Sep 8, 2022
@OSBotify
Copy link
Contributor Author

OSBotify commented Sep 8, 2022

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.98-0 🚀

@Julesssss
Copy link
Contributor

Checking off #10867 as there's no testing required

@mvtglobally
Copy link

@Julesssss Regression is almost completed.

PR #10455 - We are not sure how to test this. Video and steps do not match. Need some help with this one.
PR #10488 (comment) - QA team is not able to test Wallet
PR #10659 is failing #9705. Since its in PROD. Checking off
PR #10723 is failing #10897. Its not in PROD, but as a new feature. Are we ok to check off or this will be a blocker?

Finishing few TR steps as well. Will share final summary in a bit

@chiragsalian
Copy link
Contributor

PR #10723 is failing #10897. Its not in PROD, but as a new feature. Are we ok to check off or this will be a blocker?

Yes, looks like the issue is just with the offline part, wherein when coming back online the workspace disappears. Not deploy blocker worthy so I'll check it off.

@OSBotify
Copy link
Contributor Author

OSBotify commented Sep 8, 2022

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.98-1 🚀

@mvtglobally
Copy link

@chiragsalian Regression is completed.

@OSBotify
Copy link
Contributor Author

OSBotify commented Sep 8, 2022

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.98-1 has been deployed to staging 🎉

@chiragsalian
Copy link
Contributor

Im checking #10901, since we're trying to get #10908 out the door soon as its affecting customers. #10901 is also an edge case and I wasn't able to reproduce it.

@chiragsalian
Copy link
Contributor

:shipit:

@Julesssss
Copy link
Contributor

Thanks @chiragsalian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

5 participants