Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] iOS - Chat - The keyboard opens and covers the compose box when have message with a draft #11118

Closed
kbecciv opened this issue Sep 19, 2022 · 13 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Sep 19, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the App
  2. Login with any account
  3. Navigate to a conversation (conv 1)
    4.Click on the Pin icon on top right to pin the conversation to the top of LHN
  4. Navigate to another conversation (conv 2)
    6.Write something on compose box and navigate away from the conversation
  5. Navigate to settings by clicking on the user avatar over the LHN
    8.Click on preferences
  6. Click on the Priority Mode option and select “#focus”
  7. We alternately open a conversation with a draft and a pinned conversation

Expected Result:

The keyboard should not close the compose box.

Actual Result:

The keyboard opens and covers the composed box when have message with a draft

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • iOS

Version Number: 1.2.2.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5739113_mweb_1909.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Sep 19, 2022

Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kbecciv kbecciv changed the title iOS - Chat - The keyboard opens and covers the composed box when have message with a draft iOS - Chat - The keyboard opens and covers the compose box when have message with a draft Sep 19, 2022
@Beamanator Beamanator added Weekly KSv2 and removed Daily KSv2 labels Sep 20, 2022
@Beamanator
Copy link
Contributor

This looks like a useful one to fix, but I'll put it on hold & make it Weekly since we're collecting all keyboard initiative issue 👍

@Beamanator Beamanator changed the title iOS - Chat - The keyboard opens and covers the compose box when have message with a draft [HOLD Keyboard initiative] iOS - Chat - The keyboard opens and covers the compose box when have message with a draft Sep 20, 2022
@JmillsExpensify JmillsExpensify changed the title [HOLD Keyboard initiative] iOS - Chat - The keyboard opens and covers the compose box when have message with a draft [HOLD Keyboard initiative] [Bug] iOS - Chat - The keyboard opens and covers the compose box when have message with a draft Sep 21, 2022
@JmillsExpensify JmillsExpensify changed the title [HOLD Keyboard initiative] [Bug] iOS - Chat - The keyboard opens and covers the compose box when have message with a draft [HOLD #10273] [Bug] iOS - Chat - The keyboard opens and covers the compose box when have message with a draft Sep 27, 2022
@melvin-bot melvin-bot bot added the Overdue label Sep 29, 2022
@Beamanator
Copy link
Contributor

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label Oct 3, 2022
@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@melvin-bot melvin-bot bot added the Overdue label Oct 11, 2022
@Beamanator
Copy link
Contributor

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label Oct 12, 2022
@tgolen tgolen assigned tgolen and unassigned Beamanator Oct 12, 2022
@tgolen tgolen changed the title [HOLD #10273] [Bug] iOS - Chat - The keyboard opens and covers the compose box when have message with a draft [Bug] iOS - Chat - The keyboard opens and covers the compose box when have message with a draft Oct 13, 2022
@tgolen tgolen added the Reviewing Has a PR in review label Oct 13, 2022
@tgolen
Copy link
Contributor

tgolen commented Oct 13, 2022

I removed the HOLD on this and assigned it to me because this is fixed in #11586

@mvtglobally
Copy link

Issue not reproducible during KI retests. (Second week)

@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022
@mvtglobally
Copy link

Issue not reproducible during KI retests. (Third week) Closing

@melvin-bot
Copy link

melvin-bot bot commented Oct 28, 2022

BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed:

  • A regression test has been added or updated so that the same bug will not reach production again. Link to the updated test here:
  • The PR that introduced the bug has been identified. Link to the PR:
  • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • Payment has been made to the issue reporter (if applicable)
  • Payment has been made to the contributor that fixed the issue (if applicable)
  • Payment has been made to the contributor+ that helped on the issue (if applicable)

4 similar comments
@melvin-bot

This comment was marked as duplicate.

@melvin-bot

This comment was marked as duplicate.

@melvin-bot
Copy link

melvin-bot bot commented Nov 3, 2022

BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed:

  • A regression test has been added or updated so that the same bug will not reach production again. Link to the updated test here:
  • The PR that introduced the bug has been identified. Link to the PR:
  • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • Payment has been made to the issue reporter (if applicable)
  • Payment has been made to the contributor that fixed the issue (if applicable)
  • Payment has been made to the contributor+ that helped on the issue (if applicable)

@melvin-bot
Copy link

melvin-bot bot commented Nov 3, 2022

BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed:

  • A regression test has been added or updated so that the same bug will not reach production again. Link to the updated test here:
  • The PR that introduced the bug has been identified. Link to the PR:
  • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • Payment has been made to the issue reporter (if applicable)
  • Payment has been made to the contributor that fixed the issue (if applicable)
  • Payment has been made to the contributor+ that helped on the issue (if applicable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants