Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [OptionsSelector] The cursor moves to the start of the input making typing hard #11239

Closed
luacmartins opened this issue Sep 23, 2022 · 20 comments
Assignees
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Sep 23, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Coming from here

Action Performed:

  1. Tap + > Request money
  2. Type a contact name fast
  3. Notice that the cursor moves to the beginning and end of the text, making typing random

Expected Result:

User should be able to type without issues

Actual Result:

Typing is erratic because the cursor changes position

Workaround:

Type slowly

Platform:

Where is this issue occurring?

  • iOS
  • Android
  • Mobile Web

Version Number: 1.2.5-0
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @dhairyasenjaliya and @luacmartins
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1663824664105649 and https://expensify.slack.com/archives/C01GTK53T8Q/p1663949837316499

View all open jobs on GitHub

@luacmartins luacmartins added DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 labels Sep 23, 2022
@luacmartins luacmartins self-assigned this Sep 23, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@luacmartins
Copy link
Contributor Author

I can reproduce locally and reverting #11036 fixes it.

@luacmartins
Copy link
Contributor Author

This is done. Closing!

@rushatgabhane
Copy link
Member

@luacmartins Thanks for the revert, I'll look for a better fix

@dhairyasenjaliya
Copy link
Contributor

dhairyasenjaliya commented Sep 25, 2022

hello @luacmartins @rushatgabhane am I eligible for reporting this issue as I have posted this issue first in slack (22 September) but somehow got missed later on this got logged and in the GH body issue slack link is on (23 September reported by @luacmartins ) and also I have mentioned this might be a deploy blocker https://expensify.slack.com/archives/C01GTK53T8Q/p1663824664105649

@luacmartins luacmartins added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Sep 26, 2022
@luacmartins
Copy link
Contributor Author

@dhairyasenjaliya of course! Sorry that we missed your posting on Slack. I'm gonna reopen this issue and assign a contributor manager to process the payment. Thanks for bringing this up.

@luacmartins luacmartins reopened this Sep 26, 2022
@luacmartins luacmartins added the External Added to denote the issue can be worked on by a contributor label Sep 26, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 26, 2022

Triggered auto assignment to @adelekennedy (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Sep 26, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 26, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 26, 2022

Current assignee @luacmartins is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot changed the title [OptionsSelector] The cursor moves to the start of the input making typing hard [$250] [OptionsSelector] The cursor moves to the start of the input making typing hard Sep 26, 2022
@luacmartins
Copy link
Contributor Author

luacmartins commented Sep 26, 2022

@adelekennedy would you mind paying the reporting bonus to @dhairyasenjaliya? This issue was already fixed internally and you can close it once the bonus is payed.

@melvin-bot
Copy link

melvin-bot bot commented Sep 27, 2022

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@adelekennedy
Copy link

adelekennedy commented Sep 27, 2022

@dhairyasenjaliya will you apply here? I'l hire and pay out the reporting bonus!

@dhairyasenjaliya
Copy link
Contributor

@adelekennedy job seems to be "Only invited users can find, view and apply to the job"

@adelekennedy
Copy link

Updated and refreshed @dhairyasenjaliya!

@dhairyasenjaliya
Copy link
Contributor

Done @adelekennedy

@luacmartins
Copy link
Contributor Author

@dhairyasenjaliya @adelekennedy can we close this issue?

@dhairyasenjaliya
Copy link
Contributor

@luacmartins applied to the job , yet to be accepted @adelekennedy

@adelekennedy
Copy link

done!

@dhairyasenjaliya
Copy link
Contributor

dhairyasenjaliya commented Oct 4, 2022

Offer accepted @adelekennedy

@adelekennedy
Copy link

Paid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

6 participants