-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-01-11] IOS - Workspace -Units under Reimbursement-hidden by keyboard after tap on it (small phones) #11391
Comments
Triggered auto assignment to @AndrewGable ( |
Triggered auto assignment to @JmillsExpensify ( |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat ( |
Current assignee @AndrewGable is eligible for the External assigner, not assigning anyone new. |
Putting a hold on this and filing with our larger keyboard initiative. |
@JmillsExpensify, @AndrewGable, @parasharrajat Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Moved to weekly while issue is on hold pending larger keyboard updates. |
Issue not reproducible during KI retests. (First week) |
Issue not reproducible during KI retests. (Second week) |
Ok two weeks of not being able to reproduce means I think we should close, reopen if you disagree! |
@JmillsExpensify @AndrewGable QA team is discovered the same issue in Android on build 1.2.17.0 Record_2022-10-18-11-09-02_4f9154176b47c00da84e32064abf1c48.mp4 |
I'd still like to get a better idea of what the proposal would look like, but if @chrispader just wants to work in the PR to iron out the details, that's fine with me too. |
@JmillsExpensify @tgolen added a PR for this. in The changes in |
I wanted to give everyone a quick heads up that I'm OOO this week, though I intend to check in every couple of days. @tgolen if you need anything quickly on the Bug Zero side of things, it'd be great if you can handle it or raise it #bug-zero in Slack for help. Thanks! |
There will be three PRs for this issue:
It sounds like |
Yes, exactly! @tgolen Working on both of these PRs (1 & 2) right now |
Circling back on 3, do we have a separate issue for that, or we're going to hold off closing this issue until all three PRs are merged (either in this repo or upstream)? |
@JmillsExpensify, @tgolen, @hannojg, @chrispader, @parasharrajat Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Looks like we are still working through #13514, which @parasharrajat was able to review today. Woo! That said, most everyone on this issue is out for the holidays, so I'm moving this issue to weekly and we can resume daily updates next week. |
I think this issue is already fixed, right? @tgolen @JmillsExpensify |
For the most part, yes. Did we ever do this?
|
I added a PR in the upstream library. You can find it here |
Great point. So I think in that case, we need to:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Circling back to payments, this is where I think we landed.
@parasharrajat the upwork job is here: https://www.upwork.com/jobs/~014479aca2e5c69cc7. @chrispader I think Margelo is adding these to the monthly invoice, so make sure you pass the word along. |
@parasharrajat @tgolen Do both of you mind giving us a head start on the BZ checklist above? |
Sure, this one is easy since it wasn't a regression. It was just something missing from the original implementation (so technically we added a feature). |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
@parasharrajat Let's close the loop on this one. I've gone ahead and invited you to the Upwork job. |
P.S. Regression issue is created, so we'll be ready to close this out as soon as Rajat is able to accept. |
@parasharrajat has been paid out, so we should be done here. Thanks! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Units under Reimbursement should be visible after tap on it
Actual Result:
Units under Reimbursement-hidden by keyboard after tap on it
Workaround:
Unknow
Platform:
Where is this issue occurring?
Version Number: 1.2.9.0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): any
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
RPReplay_Final1664396449.MP4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: