Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace - Blueline around the fields does not disappear moving to another field #11646

Closed
kavimuru opened this issue Oct 6, 2022 · 8 comments
Assignees
Labels
Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@kavimuru
Copy link

kavimuru commented Oct 6, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the App
  2. Log with any acсount
  3. Go to Settings->Workspaсe->General settings
  4. Change the workspace name and then change the currency

Expected Result:

Two fields should not be highlighted at the same time

Actual Result:

Two fields are highlighted at the same time.
In offline mode the same.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • iOS
  • Android
  • Mobile Web

Version Number: v1.2.12-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

https://user-images.githubusercontent.com/43996225/194418742-68bde414-1896-42ab-b6c0-3ccb1afa3113.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Oct 6, 2022
@OSBotify
Copy link
Contributor

OSBotify commented Oct 6, 2022

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Oct 6, 2022

Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@chiragsalian
Copy link
Contributor

Okay i can reproduce this on dev and staging and not on production. Investigating further.

@chiragsalian
Copy link
Contributor

Looks like it will be resolved in this PR. Asking if we should CP or just not consider this as a blocker since its a minor UI issue.

@AndrewGable AndrewGable removed the DeployBlockerCash This issue or pull request should block deployment label Oct 7, 2022
@AndrewGable
Copy link
Contributor

Removed per discussion here: https://expensify.slack.com/archives/C01GTK53T8Q/p1665090504375479

@chiragsalian chiragsalian added Weekly KSv2 Reviewing Has a PR in review Hourly KSv2 and removed Hourly KSv2 Weekly KSv2 labels Oct 7, 2022
@rushatgabhane
Copy link
Member

Added in QA steps of #11039

@AndrewGable AndrewGable added Daily KSv2 and removed Hourly KSv2 labels Oct 12, 2022
@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@chiragsalian
Copy link
Contributor

Closing issue since the linked PR is on production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

6 participants