Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] mWeb/Safari - Workspace - Page jumps up and hides the search field when I focus in "Add a personal message" field #11776

Closed
kavimuru opened this issue Oct 12, 2022 · 12 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to URL https://staging.new.expensify.com/
    and login
  2. Go to Settings->Workspase->Manage members->Invite
  3. Enter the email in the search field
  4. Focusing in "Add a personal message" field

Expected Result:

Page shouldn't jumps up

Actual Result:

Page jumps up and search field disappear unlike the app

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Mobile Web

Version Number: 1.2-13-3
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5774037_RPReplay_Final1665599905.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2022

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Puneet-here
Copy link
Contributor

We will move this field to a new page after implementing push to page.

@melvin-bot melvin-bot bot added the Overdue label Oct 17, 2022
@AndrewGable AndrewGable added the External Added to denote the issue can be worked on by a contributor label Oct 17, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2022

Triggered auto assignment to @sophiepintoraetz (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@AndrewGable
Copy link
Contributor

cc @tgolen for keyboard bugs

@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 17, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2022

Current assignee @AndrewGable is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot changed the title mWeb/Safari - Workspace - Page jumps up and hides the search field when I focus in "Add a personal message" field [$250] mWeb/Safari - Workspace - Page jumps up and hides the search field when I focus in "Add a personal message" field Oct 17, 2022
@tgolen tgolen changed the title [$250] mWeb/Safari - Workspace - Page jumps up and hides the search field when I focus in "Add a personal message" field [HOLD] [$250] mWeb/Safari - Workspace - Page jumps up and hides the search field when I focus in "Add a personal message" field Oct 18, 2022
@tgolen
Copy link
Contributor

tgolen commented Oct 18, 2022

I've added a HOLD to this and added it to the tracking issue: #10273

@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 19, 2022
@sophiepintoraetz sophiepintoraetz added Weekly KSv2 and removed Daily KSv2 labels Oct 19, 2022
@melvin-bot melvin-bot bot removed the Overdue label Oct 19, 2022
@sophiepintoraetz
Copy link
Contributor

sophiepintoraetz commented Oct 19, 2022

@tgolen - new to the BZ (old contributor) process - what's the best practise managing issues that are on hold? Do we still need to source proposals? Also, what issue is it being blocked by?

@sophiepintoraetz
Copy link
Contributor

I'm going to close for now, we can reopen when it's time to action!

@JmillsExpensify
Copy link

Opening this back up now that related PR is merged. Let's re-test this and see if it's still a thing.

@melvin-bot melvin-bot bot added the Overdue label Nov 1, 2022
@JmillsExpensify JmillsExpensify changed the title [HOLD] [$250] mWeb/Safari - Workspace - Page jumps up and hides the search field when I focus in "Add a personal message" field [$250] mWeb/Safari - Workspace - Page jumps up and hides the search field when I focus in "Add a personal message" field Nov 1, 2022
@sophiepintoraetz
Copy link
Contributor

Hmm, i don't think this particular issue is happening any more but I do think there's a non-intuitive flow in expecting the user to scroll down to the welcome message (if you don't know it's there, how do you know to scroll down to look for it?) But I think that's a separate issue.

image

RPReplay_Final1667283684.MP4

@JmillsExpensify
Copy link

Awesome, thanks for re-testing! And agreed, that's a separate issue though it will be resolved in the move to push to page in N8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
None yet
Development

No branches or pull requests

8 participants