Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-01-19 #14423

Closed
21 tasks done
OSBotify opened this issue Jan 19, 2023 · 14 comments
Closed
21 tasks done

Deploy Checklist: New Expensify 2023-01-19 #14423

OSBotify opened this issue Jan 19, 2023 · 14 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Jan 19, 2023

Release Version: 1.2.57-3
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.

cc @Expensify/applauseleads

@melvin-bot melvin-bot bot locked and limited conversation to collaborators Jan 19, 2023
@mvtglobally mvtglobally added DeployBlockerCash This issue or pull request should block deployment 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging and removed DeployBlockerCash This issue or pull request should block deployment labels Jan 20, 2023
@OSBotify
Copy link
Contributor Author

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.57-0 🚀

@mvtglobally mvtglobally added 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging and removed 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging labels Jan 20, 2023
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.57-2 🚀

@mvtglobally
Copy link

@luacmartins Regression is completed

#11592 is failing #14437
#14353 is blocked on Native apps due to old KI (We are unable to setup VBA on apps). Rest platforms are pass. Let me know if ok to check it off.

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.57-3 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.57-3 has been deployed to staging 🎉

@mountiny
Copy link
Contributor

@mvtglobally Can you please retest #14437, we had CPed the fix to staging! thanks

@mvtglobally
Copy link

checking

@luacmartins luacmartins self-assigned this Jan 23, 2023
@luacmartins
Copy link
Contributor

Tested #14450 and it's a pass! @mvtglobally can you please retest #11592?

@mvtglobally
Copy link

#14437 & #14450 are pass

@luacmartins
Copy link
Contributor

#14353 is a pass!

@luacmartins
Copy link
Contributor

#11592 is a pass too!

@luacmartins
Copy link
Contributor

API timings are nominal and there are no new crashes in v1.2.57-3. Kicking off the deploy!

@luacmartins
Copy link
Contributor

:shipit:

@Expensify Expensify unlocked this conversation Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

6 participants