Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$1000] [HOLD for payment 2023-06-07] [Group 2][Accessible Pressable] Migrate BaseValidateCodeForm #17022

Closed
roryabraham opened this issue Apr 6, 2023 · 27 comments
Closed

[$1000] [HOLD for payment 2023-06-07] [Group 2][Accessible Pressable] Migrate BaseValidateCodeForm #17022

roryabraham opened this issue Apr 6, 2023 · 27 comments
Assignees
@puneetlath @abdulrahuman5196 @joekaufmanexpensify @robertKozik
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@roryabraham
Copy link
Contributor

roryabraham commented Apr 6, 2023 •
edited by melvin-bot bot
Loading

HOLD on #16988

Description

Migrate BaseValidateCodeForm to use PressableWithFeedback

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010306bc05e1c1d71d
  • Upwork Job ID: 1667273270441086976
  • Last Price Increase: 2023-06-09
@roryabraham roryabraham added the NewFeature Something to build that is a new item. label Apr 6, 2023
@roryabraham roryabraham self-assigned this Apr 6, 2023
@MelvinBot

This comment was marked as resolved.

Sign in to view
@melvin-bot melvin-bot bot added the Weekly KSv2 label Apr 6, 2023
@roryabraham roryabraham added Monthly KSv2 and removed Weekly KSv2 labels Apr 6, 2023
@roryabraham roryabraham removed their assignment Apr 6, 2023
@roryabraham roryabraham changed the title [HOLD][Group 2][Accessible Pressable] Migrate BaseValidateCodeForm [Group 2][Accessible Pressable] Migrate BaseValidateCodeForm May 11, 2023
@melvin-bot melvin-bot bot added the Overdue label May 11, 2023
@robertKozik
Copy link
Contributor

@roryabraham can you assign me to this one?

@robertKozik robertKozik mentioned this issue May 25, 2023
Merged
57 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Overdue Monthly KSv2 labels May 25, 2023
@melvin-bot melvin-bot bot changed the title [Group 2][Accessible Pressable] Migrate BaseValidateCodeForm [HOLD for payment 2023-06-07] [Group 2][Accessible Pressable] Migrate BaseValidateCodeForm May 31, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 31, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 31, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented May 31, 2023 •
edited by joekaufmanexpensify
Loading

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.20-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@abdulrahuman5196
Copy link
Contributor

@roryabraham Could you kindly assign this issue to me for C+ review completion?

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 6, 2023
@abdulrahuman5196
Copy link
Contributor

abdulrahuman5196 commented Jun 7, 2023 •
edited
Loading

@roryabraham Could you kindly check on the above?

@thienlnam thienlnam removed the NewFeature Something to build that is a new item. label Jun 9, 2023
@melvin-bot melvin-bot bot removed Daily KSv2 Overdue labels Jun 9, 2023
@thienlnam
Copy link
Contributor

Ah, I guess assigning the label won't work since Puneet is also a BZ member. I just assigned @joekaufmanexpensify since he was the original assignee on the issue.

@joekaufmanexpensify Can you please handle payment for this issue? Just an internal C+ review to @abdulrahuman5196

@joekaufmanexpensify joekaufmanexpensify added the External Added to denote the issue can be worked on by a contributor label Jun 9, 2023
@joekaufmanexpensify
Copy link
Contributor

Sure!

@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-06-07] [Group 2][Accessible Pressable] Migrate BaseValidateCodeForm [$1000] [HOLD for payment 2023-06-07] [Group 2][Accessible Pressable] Migrate BaseValidateCodeForm Jun 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 9, 2023

Job added to Upwork: https://www.upwork.com/jobs/~010306bc05e1c1d71d

@melvin-bot
Copy link

melvin-bot bot commented Jun 9, 2023

Current assignees @puneetlath and @joekaufmanexpensify are eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 9, 2023

Current assignee @abdulrahuman5196 is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 9, 2023

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

@Vishrut19
Copy link
Contributor

I want to work on it

@joekaufmanexpensify
Copy link
Contributor

Added external label to handle payment.

@joekaufmanexpensify
Copy link
Contributor

@abdulrahuman5196 offer sent for $1,000!

@abdulrahuman5196
Copy link
Contributor

@joekaufmanexpensify accepted the offer.

@thesahindia
Copy link
Member

@abdulrahuman5196 offer sent for $1,000!

I think the compensation for the C+ review is $250 for migration and refactor related issues.

@abdulrahuman5196
Copy link
Contributor

Not entirely sure. I have seen similar migration bugs with 1k tag as well as 250 tag. (Mostly marked before review)
But anyways would be fine with teams decision.

@abdulrahuman5196
Copy link
Contributor

It seems newer migration issue reviews are made at lower cap of 250$ - #17012 (comment) and older reviews are fine with flat internal review. I think this should also fall into the older bucket of flat review compensation based on the timeline. But anyways team could correct me here.

@0xmiros
Copy link
Contributor

0xmiros commented Jun 11, 2023

I noticed inconsistency in compensation.
Some issues are still $1000 even PR not merged yet:

Some issues are $250 even PR was merged before the announcement:

@roryabraham can we standardize this? i.e. for the PR merged before Jun 1, compensate $1000. Otherwise $250.

@roryabraham
Copy link
Contributor Author

Posted an announcement in slack: https://expensify.slack.com/archives/C02NK2DQWUX/p1686526913675359

@thienlnam thienlnam removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 12, 2023
@joekaufmanexpensify
Copy link
Contributor

@abdulrahuman5196 I confirmed that this payment for this issue should have been $250 all along, rather than $1,000. So going to issue payment for $250. Apologies for the miscommunication, and LMK if you have any questions!

@abdulrahuman5196
Copy link
Contributor

Sure @joekaufmanexpensify

@joekaufmanexpensify
Copy link
Contributor

@abdulrahuman5196 Great, thanks! $250 sent and contract ended.

@joekaufmanexpensify
Copy link
Contributor

Upwork job closed.

@joekaufmanexpensify
Copy link
Contributor

Closing as this is all set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@puneetlath puneetlath

@abdulrahuman5196 abdulrahuman5196

@joekaufmanexpensify joekaufmanexpensify

@robertKozik robertKozik

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
No open projects
Accessible Pressables
Status: Done
Milestone
No milestone
Development

No branches or pull requests
10 participants
@puneetlath @MelvinBot @thienlnam @abdulrahuman5196 @roryabraham @Vishrut19 @joekaufmanexpensify @robertKozik @thesahindia @0xmiros