[$1000] 'validateCodeForm.codeSent' is displayed when clicking 'Request a new code here' instead of displaying a normal text for the users

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to web chrome on staging
2. Log out and enter your email that you haven't used for signing with a magic code earlier
3. Now check your mail and click on the link 'Click onto sign in to your expensify account'
4. A new page appears
5. Click on the link 'just sign in here'
6. Then click on the link 'Request a new code' and notice that it displays message like 'validateCodeForm.codeSent' instead of a normal text

Expected Result:

Normal message should be displayed instead of 'validateCodeForm.codeSent'

Actual Result:

'validateCodeForm.codeSent' is displayed on clicking 'just sign in here'.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

code.mp4

Recording.328.mp4

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682137890899889

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010f1880da5fbe2921
• Upwork Job ID: 1654566323152588800
• Last Price Increase: 2023-05-05

[MelvinBot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[priya-zha]

As per the conversation here in Slack, https://expensify.slack.com/archives/C049HHMV9SM/p1682137890899889, to reproduce the issue, please make sure to have logged out from the new.expensify.com in production. Thus, go to new.expensify.com and if you are already logged in, please log out and then following the above mentioned steps in the staging dot would help to reproduce the bug.

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

validateCodeForm.codeSent is shown on the ExpiredValidateCodeModel

What is the root cause of that problem?

The root cause is that we're not wrapping the message inside the translate function.

What changes do you think we should make in order to solve the problem?

We need to replace codeRequestedMessage with this.props.translate(codeRequestedMessage) here.
This is consistent with how this message is being displayed here and here.

I also noticed that we're using the codeRequestedErrors text without translation here as well. We thus need to wrap this inside the translate function as well.

What alternative solutions did you explore? (Optional)

None

[mollfpr]

Thanks @allroundexperts for the proposal! This is a regression from #17216, so @Pujan92 will work on this to fix it.

cc @tgolen @puneetlath

[Pujan92]

@mollfpr are you able to reach out to this page in dev env?
Able to land on this page.

[mollfpr]

@Pujan92 Actually, I haven't! How do you do it?

[Pujan92]

@Pujan92 Actually, I haven't! How do you do it?

Once received magic link email, try to open a previous expired link. With this, you will get that page and link request a new code here

[MelvinBot]

@puneetlath Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010f1880da5fbe2921

[melvin-bot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[melvin-bot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[puneetlath]

Marking as External just so we can get @priya-zha paid out for the issue report. All other payments will be handled on #17216.

@priya-zha can you apply to https://www.upwork.com/jobs/~010f1880da5fbe2921 please?

[priya-zha]

@puneetlath Submitted the proposal. Thanks.

[puneetlath]

All paid!