[$2000] HIGH: Implement Comment Linking

[mountiny]

This is a public issue to track implementation of the Comment Linking feature (internal link).

Margelo will work on the App implementation of this project

Design doc can be found here - also internal

Roll out plan

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0116b1ab0be62d4242
• Upwork Job ID: 1777848479203676160
• Last Price Increase: 2024-04-10

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Current assignee @puneetlath is eligible for the NewFeature assigner, not assigning anyone new.

[perunt]

I would like to do this

[puneetlath]

@chiragsalian I don't think you need me here so going to un-assign. But feel free to re-assign me if I missed something.

[perunt]

@chiragsalian could you apply the Review label to this doc?

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[ishpaul777]

@roryabraham Can this be reopened for C+ payment

[ishpaul777]

friendly bump @roryabraham

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0116b1ab0be62d4242

[melvin-bot]

Current assignee @ishpaul777 is eligible for the External assigner, not assigning anyone new.

[roryabraham]

@puneetlath I reopened this so that @ishpaul777 can get paid for his role as a C+ for comment linking. I suggest a payment of $1000 with no regression penalties because:

• this was a big, challenging PR
• @ishpaul777 was very diligent in going above-and-beyond to help us resolve any regressions created by the feature

[melvin-bot]

Upwork job price has been updated to $1000

[ishpaul777]

Thank you for the recognition and for advocating against any penalties. I truly appreciate the acknowledgment of my efforts. In light of the complexity and dedication involved, I would like to suggest adjustment to the proposed payment. Would it be possible to consider a increase, making it $2000? However, if you feel otherwise, I am completely okay. Again thank you for your understanding.

[roryabraham]

Hi @ishpaul777, I chatted with @puneetlath and given the difficulty and scope of work, along with all the extra time you spent going above-and-beyond to help deliver the feature, we're willing to authorize $2000 for this issue 👍🏼

[melvin-bot]

Upwork job price has been updated to $2000

[ishpaul777]

Thank you 🤗 🤩

[puneetlath]

Sent you an offer @ishpaul777: https://www.upwork.com/nx/wm/offer/101826333

Please ping me here when you've accepted.

[ishpaul777]

Accepted 😄

[puneetlath]

Great, paid. Thanks everyone. Exciting to have comment linking out in the wild!