Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-07-20] Display money request reports as a card in the chat report #20893

Closed
Gonals opened this issue Jun 16, 2023 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Weekly KSv2

Comments

@Gonals
Copy link
Contributor

Gonals commented Jun 16, 2023

Currently, money request reports are displayed in-chat as plain text like so:
Potato owes $535.35

It doesn't look great. Let's change it so it is styled like a card (like individual requests) in preparation for receipts

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b4227ab04073e43a
  • Upwork Job ID: 1669636120412647424
  • Last Price Increase: 2023-06-16
@Gonals Gonals added Weekly KSv2 Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff labels Jun 16, 2023
@Gonals Gonals self-assigned this Jun 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 16, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01b4227ab04073e43a

@melvin-bot
Copy link

melvin-bot bot commented Jun 16, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @narefyev91 (Internal)

@melvin-bot
Copy link

melvin-bot bot commented Jul 10, 2023

This issue has not been updated in over 15 days. @Gonals, @narefyev91 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Monthly KSv2 labels Jul 13, 2023
@melvin-bot melvin-bot bot changed the title Display money request reports as a card in the chat report [HOLD for payment 2023-07-20] Display money request reports as a card in the chat report Jul 13, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 13, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 13, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Jul 13, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.39-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-07-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Jul 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 24, 2023

@Gonals, @narefyev91 Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot
Copy link

melvin-bot bot commented Jul 28, 2023

@Gonals, @narefyev91 Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@Gonals Gonals added the NewFeature Something to build that is a new item. label Jul 31, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 31, 2023

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jul 31, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 31, 2023

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

@Gonals
Copy link
Contributor Author

Gonals commented Jul 31, 2023

@mallenexpensify, I just realized I forgot to add the newFeature label back when I created this. I think we just need to handle payment for the C+ reviewer

@melvin-bot melvin-bot bot added the Overdue label Aug 8, 2023
@shawnborton
Copy link
Contributor

Is the payment part handled yet?

@melvin-bot melvin-bot bot removed the Overdue label Aug 10, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 21, 2023
@shawnborton
Copy link
Contributor

Friendly bump @mallenexpensify

@melvin-bot melvin-bot bot removed the Overdue label Aug 21, 2023
@mallenexpensify
Copy link
Contributor

Checking on payment formatting here

@mallenexpensify
Copy link
Contributor

No payment dude, @narefyev91 is with Callstack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants