[Hold PR#25935][$1000] Android - Chat - New unread message is marked read when user reads old unread message offline

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Precondition: There is unread message.

1. Launch New Expensify app.
2. Disconnect network.
3. Read the unread message.
4. Return to LHN.
5. As another user on another device, send a message to app user.
6. As mobile app user, reconnect network.

Expected Result:

The unread message will be marked unread (bold).

Actual Result:

The unread message is marked unread for a while and then marked read (not bold).

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.29.0

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6094384_Screen_Recording_20230616_003135_New_Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0197d6914a40bd4242
• Upwork Job ID: 1671500870756126720
• Last Price Increase: 2023-06-28

[melvin-bot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

@flaviadefaria Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0197d6914a40bd4242

[melvin-bot]

Current assignee @flaviadefaria is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[flaviadefaria]

Added the external label.

[ginsuma]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android - Chat - New unread message is marked read when user reads old unread message offline

What is the root cause of that problem?

When we are offline, we open a report and save this OpenReport command.
When we are back online, we receive an unread message and the saved request are sent and it updates the lastReadTime of report to that time of moment. Therefore, the unread massage was created before is masked read.

What changes do you think we should make in order to solve the problem?

When we are offline, we should send request for marking comment as read instead of OpenReport.
We are having markCommentAsUnread function so we can make markCommentAsRead function for the latest comment with adding 1 millisecond.
Adding condition to check if network is offline at openReportIfNecessary function in ReportActionsView

From BE:
For the case one user in multi sessions, there are both online and offline, in MarkAsRead command, if lastReadTime in database is greater than lastReadTime in params, we won't update it.

Result:

Screen.Recording.2023-06-22.at.11.44.43.PM.mov

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

📣 @ginsuma! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[flaviadefaria]

@fedirjh any thoughts on the proposal above?

[fedirjh]

I will review the proposal tomorrow.

[flaviadefaria]

Thanks for the update looking forward to your review!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[flaviadefaria]

@fedirjh do you have an update here?

[fedirjh]

@flaviadefaria I believe this issue will be handled in #15212 , following the general design proposed by @MonilBhavsar in this discussion , that will cover this case . I suggest we put this issue on hold and add it to the tracker issue.

[flaviadefaria]

Cool I put this on hold and added it to the tracking issue so will now switch it monthly to wait until we can revisit this.

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[flaviadefaria]

@trjExpensify I'm officially no longer in the BugZero team so reassigning this as it will not close until tomorrow.

[trjExpensify]

Cool, cool! Thankfully, this issue's history is small, but it would be helpful to give BZs you're handing over to some context on the issues you're reassigning with regards to where they're at. Similar to how people do when they go OoO and reassign.

[trjExpensify]

Updating the title of this issue to reflect the PR it's held on and updated to weekly because of that hold.

[trjExpensify]

@fedirjh is there an update on this one?

[fedirjh]

Still on hold, PR is still under review :

• Updated logic to handle unread messages case #25935

[trjExpensify]

Got it, seems like it has been in review for quite some time. There's conflicts again now FYI. :)

[trjExpensify]

Looks like C+ review is done, so hopefully next time around we can take this off hold.

[trjExpensify]

Merged, hasn't hit staging yet. @fedirjh will you be able to retest this one on Android once it does?

[MonilBhavsar]

This issue should be fixed. I think we can retest and most probably close it

[fedirjh]

@trjExpensify I retested on Android and can confirm that it was fixed :

CleanShot.2023-11-21.at.21.16.31.mp4

[trjExpensify]

Excellent. Issue was reported by Applause, closing it out.