Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement displaying a single waypoint #22706

Closed
neil-marcellini opened this issue Jul 11, 2023 · 15 comments
Closed

Implement displaying a single waypoint #22706

neil-marcellini opened this issue Jul 11, 2023 · 15 comments

Comments

@neil-marcellini
Copy link
Contributor

Please follow the plan in the design doc.

@melvin-bot
Copy link

melvin-bot bot commented Jul 17, 2023

Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Jul 17, 2023
@neil-marcellini
Copy link
Contributor Author

On HOLD, changing to a weekly while I wait.

@melvin-bot melvin-bot bot removed the Overdue label Jul 18, 2023
@neil-marcellini neil-marcellini added Weekly KSv2 and removed Daily KSv2 labels Jul 18, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 26, 2023
@neil-marcellini
Copy link
Contributor Author

On hold

@melvin-bot melvin-bot bot removed the Overdue label Jul 26, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 4, 2023
@neil-marcellini
Copy link
Contributor Author

Still holding

@melvin-bot melvin-bot bot removed the Overdue label Aug 4, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 14, 2023
@neil-marcellini
Copy link
Contributor Author

Holding

@melvin-bot melvin-bot bot removed the Overdue label Aug 15, 2023
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Aug 17, 2023
@neil-marcellini neil-marcellini changed the title [HOLD 22705] Implement displaying a single waypoint Implement displaying a single waypoint Aug 17, 2023
@neil-marcellini neil-marcellini added Daily KSv2 and removed Weekly KSv2 labels Aug 17, 2023
@neil-marcellini
Copy link
Contributor Author

Off hold now since Hayata got started

@melvin-bot
Copy link

melvin-bot bot commented Aug 21, 2023

Triggered auto assignment to @dannymcclain (Design), see these Stack Overflow questions for more details.

@hayata-suenaga
Copy link
Contributor

hello @dannymcclain 👋

We're working on a new project called "Distance Request" where users can request expenses they spend on gas to be reimbursed through NewDot. We display a map as part of this new feature to indicate the distance the user has driven.

We have design in this Figma file. Could you work with @shawnborton to compare the screenshots/videos in this Pull Request (actual code change) with the original design and confirm they look okay? 🙇

@shawnborton
Copy link
Contributor

We're discussing some finishing touches here - looks like we might want to change the style of the markers, assuming that's cool for you all!

@hayata-suenaga
Copy link
Contributor

looks like we might want to change the style of the markers, assuming that's cool for you all!

of course! wow, all options discussed in the thread look good to me 😮

@melvin-bot
Copy link

melvin-bot bot commented Aug 22, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Aug 28, 2023
@melvin-bot melvin-bot bot changed the title Implement displaying a single waypoint [HOLD for payment 2023-09-04] Implement displaying a single waypoint Aug 28, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Aug 28, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 28, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Aug 28, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.57-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-09-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@hayata-suenaga
Copy link
Contributor

No need for payment

@hayata-suenaga hayata-suenaga changed the title [HOLD for payment 2023-09-04] Implement displaying a single waypoint Implement displaying a single waypoint Aug 28, 2023
@hayata-suenaga hayata-suenaga removed the Awaiting Payment Auto-added when associated PR is deployed to production label Aug 28, 2023
@hayata-suenaga
Copy link
Contributor

I think we can close this one now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants