Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-08-02] [HOLD for payment 2023-07-24] [$1000] Web - Pasting text or link in edit message pastes the text or link in main compose box #22803

Closed
1 of 6 tasks
kbecciv opened this issue Jul 13, 2023 · 47 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kbecciv
Copy link

kbecciv commented Jul 13, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

. Open the app
2. Open any report
3. Send any message
4. Copy any text
5. Edit message sent in step 3
6. Paste the text in edit message and observe that text is pasted in compose box

Expected Result:

App should paste text in edit message if edit message is in focus

Actual Result:

App pastes text in main compose box even if edit message is in focus

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.40-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

edit.paste.not.working.mp4
Recording.3586.mp4

Expensify/Expensify Issue URL:
Issue reported by: GH handle - @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689249016488049

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019d975b520ddadde8
  • Upwork Job ID: 1679978909772632064
  • Last Price Increase: 2023-07-14
@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jul 13, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jul 13, 2023

Triggered auto assignment to @cristipaval (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@situchan
Copy link
Contributor

Might be related to #21583

@cristipaval
Copy link
Contributor

@robertKozik Are you looking into this one? (I saw your comment here)

@robertKozik
Copy link
Contributor

Yeah, I'm looking on it. Probably have the fix, just need to double check it

@robertKozik
Copy link
Contributor

I've created PR with fix: #22817

@francoisl francoisl added the Reviewing Has a PR in review label Jul 13, 2023
@francoisl francoisl removed the DeployBlockerCash This issue or pull request should block deployment label Jul 13, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 13, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@ahmdshrif
Copy link
Contributor

ahmdshrif commented Jul 13, 2023

since this fix pr will revert to this issue #22833
I have a Proposal to fix both
you can check it out here #22833 (comment)
cc: @Santhosh-Sellavel

@Santhosh-Sellavel
Copy link
Collaborator

@robertKozik this is the problem at hand now

Revert fixes ✅ #22833

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Hourly KSv2 labels Jul 14, 2023
@melvin-bot melvin-bot bot changed the title Web - Pasting text or link in edit message pastes the text or link in main compose box [HOLD for payment 2023-07-21] Web - Pasting text or link in edit message pastes the text or link in main compose box Jul 14, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 14, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 14, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Jul 14, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.40-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-07-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@Santhosh-Sellavel
Copy link
Collaborator

@robertKozik Any update?

@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-07-24] [$1000] Web - Pasting text or link in edit message pastes the text or link in main compose box [HOLD for payment 2023-08-02] [HOLD for payment 2023-07-24] [$1000] Web - Pasting text or link in edit message pastes the text or link in main compose box Jul 26, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 26, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Jul 26, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.45-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-08-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added the Overdue label Aug 3, 2023
@cristipaval cristipaval added Daily KSv2 and removed Weekly KSv2 labels Aug 4, 2023
@melvin-bot melvin-bot bot removed the Overdue label Aug 4, 2023
@cristipaval
Copy link
Contributor

cristipaval commented Aug 4, 2023

Making this daily as the payment seems to be due here.

@melvin-bot melvin-bot bot added the Overdue label Aug 7, 2023
@zanyrenney
Copy link
Contributor

zanyrenney commented Aug 7, 2023

I am working on this now @cristipaval - I was OOO before.

@melvin-bot melvin-bot bot removed the Overdue label Aug 7, 2023
@zanyrenney
Copy link
Contributor

Hmm, there is no accompanying upwork job. The only payment on Upwork also is the issue reporter, as per the comment above @cristipaval 👍🏼

@robertKozik does not require payment (Contractor)
@Santhosh-Sellavel does not require payment (Eligable for Manual Requests)

@zanyrenney
Copy link
Contributor

Upwork isn't letting me create a new job, keep getting an error. I will do this ASAP but looking like tomorrow so I can do a full clear cache, logout.

@Santhosh-Sellavel
Copy link
Collaborator

No Payments are due here for Myself & @robertKozik as it is a regression handling.

I think we can skip the checklist here as well.
All parties are aware of the mistake, and these tests will decide on the origin issue.

@melvin-bot melvin-bot bot added the Overdue label Aug 9, 2023
@cristipaval
Copy link
Contributor

Thanks @Santhosh-Sellavel!
@zanyrenney the only due payment is the reporting bonus for @dhanashree-sawant!

@melvin-bot melvin-bot bot removed the Overdue label Aug 10, 2023
@cristipaval
Copy link
Contributor

@zanyrenney Feel free to close the issue if the reporting bonus is already paid.

@melvin-bot melvin-bot bot added the Overdue label Aug 14, 2023
@zanyrenney
Copy link
Contributor

Still waiting on @dhanashree-sawant to accept job offer and finish payout - link is here https://www.upwork.com/jobs/~019f97a860cbdfce94

@melvin-bot melvin-bot bot removed the Overdue label Aug 14, 2023
@dhanashree-sawant
Copy link

Hi @zanyrenney, when I click on the job link, it is giving me 'Access denied' error

@dhanashree-sawant
Copy link

Hi @zanyrenney, I have just recieved the invite but job is kept hourly, can you change that to fixed price?

@zanyrenney
Copy link
Contributor

new upwork job - https://www.upwork.com/jobs/~011e7524a423ae1245

@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@zanyrenney
Copy link
Contributor

reporting bonus paid.

all other payments handled via NewDot. closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests