[HOLD for payment 2023-09-04] [$1000] Web - Money request - Copy to clipboard button does not copy content of an IOU edit comment #24569

izarutskaya · 2023-08-15T10:34:21Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Make money request from account A to account B
Click on the IOU preview component twice
Click on the amount and change it
Hover over the posted comment and click on copy to clipboard
Paste the content elsewhere

Expected Result:

The content should be copied when clicking on the copy to clipboard icon

Actual Result:

Nothing gets copied when clicking the copy to clipboard icon

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: v1.3.54-7

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

-14993053652749344022023-08-14_23_41_07.MP4

Recording.1201.mp4

Expensify/Expensify Issue URL:

Issue reported by: @Nathan-Mulugeta

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692045636871669

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~015fd8284ce80abac6
Upwork Job ID: 1691425057366032384
Last Price Increase: 2023-08-15
Automatic offers:

hungvu193 | Contributor | 26158030
Nathan-Mulugeta | Reporter | 26158033

melvin-bot · 2023-08-15T10:34:26Z

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-08-15T10:34:28Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

OSBotify · 2023-08-15T10:35:45Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot · 2023-08-15T10:35:49Z

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

hungvu193 · 2023-08-15T10:46:09Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Money request - Copy to clipboard button does not copy content of an IOU edit comment

What is the root cause of that problem?

We're using this code below to copy message to clipboard, since we introduced new type of reportAction called "MODIFIEDEXPENSE", we didn't format it before copying, which caused the issue

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 187 to 205 in 56f0b0f

    
           const isAttachment = _.has(reportAction, 'isAttachment') ? reportAction.isAttachment : ReportUtils.isReportMessageAttachment(message); 
        
           if (!isAttachment) { 
        
               const content = selection || messageHtml; 
        
               if (isReportPreviewAction) { 
        
                   const iouReport = ReportUtils.getReport(ReportActionUtils.getIOUReportIDFromReportActionPreview(reportAction)); 
        
                   const displayMessage = ReportUtils.getReportPreviewMessage(iouReport, reportAction); 
        
                   Clipboard.setString(displayMessage); 
        
               } else if (content) { 
        
                   const parser = new ExpensiMark(); 
        
                   if (!Clipboard.canSetHtml()) { 
        
                       Clipboard.setString(parser.htmlToMarkdown(content)); 
        
                   } else { 
        
                       const plainText = parser.htmlToText(content); 
        
                       Clipboard.setHtml(content, plainText); 
        
                   } 
        
               } 
        
           } else { 
        
               Clipboard.setString(messageHtml); 
        
           }

What changes do you think we should make in order to solve the problem?

We should update our copy to clip board action, if it's isModifiedExpenseAction, we should format the message before copying by adding more condition here:

else if (ReportActionUtils.isModifiedExpenseAction(reportAction)) {
const displayMessage = ReportUtils.getModifiedExpenseMessage(reportAction);
Clipboard.setString(displayMessage);
}

We should also update our shouldShow condition of copyToClipboard to make it show with ~~ReportPreview~~ TaskPreview:

    shouldShow: (type, reportAction) =>
        type === CONTEXT_MENU_TYPES.REPORT_ACTION &&
        reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.TASKCANCELLED &&
        reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.TASKCOMPLETED &&
        reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.TASKREOPENED &&
        !ReportUtils.isReportMessageAttachment(_.last(lodashGet(reportAction, ['message'], [{}]))) &&
        !ReportActionUtils.isMessageDeleted(reportAction),

In order to show copy option with task, we can also remove these three condition from above condition:

        reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.TASKCANCELLED &&
        reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.TASKCOMPLETED &&
        reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.TASKREOPENED &&

What alternative solutions did you explore? (Optional)

N/A

dukenv0307 · 2023-08-15T10:50:40Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Money request - Copy to clipboard button does not copy content of an IOU edit comment

What is the root cause of that problem?

For preview action

We hide the copy option for TaskPreview and IOU Preview

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 169 to 177 in 56f0b0f

    
           shouldShow: (type, reportAction) => 
        
               type === CONTEXT_MENU_TYPES.REPORT_ACTION && 
        
               reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.IOU && 
        
               reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.TASKCANCELLED && 
        
               reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.TASKCOMPLETED && 
        
               reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.TASKREOPENED && 
        
               !ReportActionUtils.isCreatedTaskReportAction(reportAction) && 
        
               !ReportUtils.isReportMessageAttachment(_.last(lodashGet(reportAction, ['message'], [{}]))) && 
        
               !ReportActionUtils.isMessageDeleted(reportAction),

For ModifiedExpenseMessage, the message display is generated by getModifiedExpenseMessage function.

App/src/pages/home/report/ReportActionItem.js

Line 321 in 56f0b0f

    
           children = <ReportActionItemBasicMessage message={ReportUtils.getModifiedExpenseMessage(props.action)} />;

But when we click on copyToClipBorad, we don't check to get modified expense message if the action is ModifiedExpenseAction action

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 190 to 195 in 56f0b0f

    
           if (isReportPreviewAction) { 
        
               const iouReport = ReportUtils.getReport(ReportActionUtils.getIOUReportIDFromReportActionPreview(reportAction)); 
        
               const displayMessage = ReportUtils.getReportPreviewMessage(iouReport, reportAction); 
        
               Clipboard.setString(displayMessage); 
        
           } else if (content) { 
        
               const parser = new ExpensiMark();

What changes do you think we should make in order to solve the problem?

We should update the check to show copy option for IOUPreview and TaskPreview as well

type === CONTEXT_MENU_TYPES.REPORT_ACTION &&
reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.TASKCANCELLED &&
reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.TASKCOMPLETED &&
reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.TASKREOPENED &&
!ReportUtils.isReportMessageAttachment(_.last(lodashGet(reportAction, ['message'], [{}]))) &&
!ReportActionUtils.isMessageDeleted(reportAction),

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 169 to 177 in 56f0b0f

    
           shouldShow: (type, reportAction) => 
        
               type === CONTEXT_MENU_TYPES.REPORT_ACTION && 
        
               reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.IOU && 
        
               reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.TASKCANCELLED && 
        
               reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.TASKCOMPLETED && 
        
               reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.TASKREOPENED && 
        
               !ReportActionUtils.isCreatedTaskReportAction(reportAction) && 
        
               !ReportUtils.isReportMessageAttachment(_.last(lodashGet(reportAction, ['message'], [{}]))) && 
        
               !ReportActionUtils.isMessageDeleted(reportAction),

and then we can add the case to get the message of this preview action in onPress function of copy option and create a function to get the display message same as ReportPreview

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 190 to 195 in 56f0b0f

    
           if (isReportPreviewAction) { 
        
               const iouReport = ReportUtils.getReport(ReportActionUtils.getIOUReportIDFromReportActionPreview(reportAction)); 
        
               const displayMessage = ReportUtils.getReportPreviewMessage(iouReport, reportAction); 
        
               Clipboard.setString(displayMessage); 
        
           } else if (content) { 
        
               const parser = new ExpensiMark();

2. We should update the copy to clip board action if the action is ModifiedExpenseAction we should get the message by getModifiedExpenseMessage function instead of getting this from action

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 190 to 195 in 56f0b0f

    
           if (isReportPreviewAction) { 
        
               const iouReport = ReportUtils.getReport(ReportActionUtils.getIOUReportIDFromReportActionPreview(reportAction)); 
        
               const displayMessage = ReportUtils.getReportPreviewMessage(iouReport, reportAction); 
        
               Clipboard.setString(displayMessage); 
        
           } else if (content) { 
        
               const parser = new ExpensiMark();

And we also update the translation for Modified Expense Message

What alternative solutions did you explore? (Optional)

We can hide the copyToClipboard if the action is ModifiedExpenseAction

BhuvaneshPatil · 2023-08-15T11:07:20Z

The link to github issue shall be posted in slack thread!

pecanoro · 2023-08-15T11:44:24Z

Discussing internally since it's a new feature!

mountiny · 2023-08-15T11:51:32Z

I think this needs to be fixed, but its not a deploy blocker.

dukenv0307 · 2023-08-15T11:52:59Z

@mountiny Can you confirm the expected here? We should hide copy option or fix to copy the current message.

0xmiros · 2023-08-15T11:56:36Z

If this is not a deploy blocker, I think better to merge this into #22387 for consistency.
There's open discussion but no one responded yet.

mountiny · 2023-08-15T12:19:56Z

Its not a deploy blocker and I would expect the behaviour to be copying what you can see on the line

pecanoro · 2023-08-15T12:21:55Z

@0xmiroslav I can't reproduce the issue you linked so I closed it since it's pretty old.

Regarding this issue, I talked to @mountiny and we decided not to block on this and have a contributor fix it!

melvin-bot · 2023-08-15T12:22:15Z

Job added to Upwork: https://www.upwork.com/jobs/~015fd8284ce80abac6

flaviadefaria · 2023-09-05T09:32:00Z

Payment summary:

@hungvu193 requires payment offer (Contributor)
@narefyev91 does not require payment (Contractor)
@Nathan-Mulugeta requires payment offer (Reporter)

@Nathan-Mulugeta = $250 reporting bonus
@hungvu193 = $1000 (no 50% bonus)

@narefyev91 can you please fill out the checklist above?

narefyev91 · 2023-09-05T10:09:21Z

The PR that introduced the bug has been identified. Link to the PR - no linked PR because it's a new implementation - no one implement fix for that flow
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug - N/A

parasharrajat · 2023-09-06T19:34:22Z

@narefyev91 @hungvu193 Please check this #26664 as it seems that PR didn't solve all cases. Let me know if you disagree. Thanks.

hungvu193 · 2023-09-07T11:22:31Z

@narefyev91 @hungvu193 Please check this #26664 as it seems that PR didn't solve all cases. Let me know if you disagree. Thanks.

I don't think so, actually we still have the logic getting the messageHtml from message.html, task action is a special case when it didn't have html field. I feel like this more a BE issue when the message got updated while originalMessage didn't.

parasharrajat · 2023-09-07T13:52:02Z

Thanks. I looked into this and yet both are different issues. technically out of scope of this issue.

parasharrajat · 2023-09-07T15:58:18Z

I debugged the other issue and I found that the #26664 is in fact related to this issue. We used originalMessage to copy the string in IOU which is the wrong thing to copy as a transaction can change.

But I wouldn't force that here.

parasharrajat · 2023-09-07T17:40:08Z

Same for #26571.

We didn't set the proper data which should have been copied for Task Preview.

parasharrajat · 2023-09-07T17:50:39Z

All of these previews should have been fixed as mentioned in #22387 (comment)

@pecanoro Do you consider #26664 & #26571 regressions from this issue or should we tackle them separately?

0xmiros · 2023-09-07T18:01:40Z

#26571 was reported on Aug 25
#26664 was reported on Aug 25
So they were both reported within regression period when PR was deployed to staging but not production

parasharrajat · 2023-09-08T16:41:01Z

Bump @pecanoro

melvin-bot · 2023-09-11T07:18:48Z

@pecanoro, @hungvu193, @narefyev91, @flaviadefaria Whoops! This issue is 2 days overdue. Let's get this updated quick!

pecanoro · 2023-09-11T08:01:04Z

Sorry! Yes, it seems like a regression, but only one regression as it's basically the same bug with the same cause. Let's fix it so it copies the updated field.

flaviadefaria · 2023-09-11T11:03:12Z

Alright payment is on hold until the regression has been fixed.

parasharrajat · 2023-09-11T20:25:36Z

I am still waiting on some sort of confirmation from the author or C+ that the linked issues will be solved as regressions.

narefyev91 · 2023-09-12T07:08:14Z

I am still waiting on some sort of confirmation from the author or C+ that the linked issues will be solved as regressions.

To be honest the changes should be done on BE side and correct string should come from it, and as I see from this comment #26621 (comment) - BE team will implement localisation on their side - and on FE we will avoid all this tricks to make it working correctly. But if we come back to initial issue - i agree that fix was not covering all possible cases

pecanoro · 2023-09-14T14:48:59Z

@narefyev91 That's a different issue, the translations are not related to the regression and should not be considered as such since it's the BE. Rajat linked another issue #26571.

@flaviadefaria Let's pay the issue with one regression, the other contributor is fixing them in their PR.

flaviadefaria · 2023-09-14T18:27:04Z

@hungvu193 requires payment offer (Contributor)
@narefyev91 does not require payment (Contractor)
@Nathan-Mulugeta requires payment offer (Reporter)

Payment Summary:

@Nathan-Mulugeta = $250 (Reporting bonus)
@hungvu193 = $1000 (no 50% bonus) - 50% (regression) = $500

flaviadefaria · 2023-09-14T18:31:06Z

Everyone has been paid and since the regression is being fixed in another issue I'll close this one.

izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 15, 2023

melvin-bot bot assigned flaviadefaria Aug 15, 2023

github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Aug 15, 2023

OSBotify mentioned this issue Aug 15, 2023

Deploy Checklist: New Expensify 2023-08-14 #24550

Closed

49 tasks

melvin-bot bot assigned pecanoro Aug 15, 2023

melvin-bot bot added Daily KSv2 and removed Hourly KSv2 labels Aug 15, 2023

0xmiros mentioned this issue Aug 15, 2023

[$1000] Copy button does not work while requesting money in newly registered Users with console error #22387

Closed

6 tasks

pecanoro mentioned this issue Aug 15, 2023

Enable editing of money requests #23703

Merged

58 tasks

mountiny removed the DeployBlockerCash This issue or pull request should block deployment label Aug 15, 2023

pecanoro added the External Added to denote the issue can be worked on by a contributor label Aug 15, 2023

melvin-bot bot changed the title ~~Web - Money request - Copy to clipboard button does not copy content of an IOU edit comment~~ [$1000] Web - Money request - Copy to clipboard button does not copy content of an IOU edit comment Aug 15, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 Daily KSv2 labels Sep 4, 2023

parasharrajat mentioned this issue Sep 7, 2023

[$500] The updated amount is not copied to clipboard. #26664

Closed

6 tasks

melvin-bot bot added the Overdue label Sep 11, 2023

melvin-bot bot removed the Overdue label Sep 11, 2023

parasharrajat mentioned this issue Sep 11, 2023

[HOLD for payment 2023-09-29] [$500] Assign task - Colon (:) added to completed/reopened task messages when copy pasting #26753

Closed

6 tasks

parasharrajat mentioned this issue Sep 11, 2023

[$500] Web - Assigned task title doesn't update when copying after changing it #26571

Closed

6 tasks

melvin-bot bot added the Overdue label Sep 14, 2023

melvin-bot bot removed the Overdue label Sep 14, 2023

flaviadefaria closed this as completed Sep 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-09-04] [$1000] Web - Money request - Copy to clipboard button does not copy content of an IOU edit comment #24569

[HOLD for payment 2023-09-04] [$1000] Web - Money request - Copy to clipboard button does not copy content of an IOU edit comment #24569

izarutskaya commented Aug 15, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Aug 15, 2023

melvin-bot bot commented Aug 15, 2023

OSBotify commented Aug 15, 2023

melvin-bot bot commented Aug 15, 2023

hungvu193 commented Aug 15, 2023 •

edited

Loading

dukenv0307 commented Aug 15, 2023 •

edited

Loading

BhuvaneshPatil commented Aug 15, 2023

pecanoro commented Aug 15, 2023

mountiny commented Aug 15, 2023

dukenv0307 commented Aug 15, 2023

0xmiros commented Aug 15, 2023

mountiny commented Aug 15, 2023

pecanoro commented Aug 15, 2023

melvin-bot bot commented Aug 15, 2023

flaviadefaria commented Sep 5, 2023

narefyev91 commented Sep 5, 2023

parasharrajat commented Sep 6, 2023

hungvu193 commented Sep 7, 2023

parasharrajat commented Sep 7, 2023 •

edited

Loading

parasharrajat commented Sep 7, 2023 •

edited

Loading

parasharrajat commented Sep 7, 2023 •

edited

Loading

parasharrajat commented Sep 7, 2023 •

edited

Loading

0xmiros commented Sep 7, 2023

parasharrajat commented Sep 8, 2023

melvin-bot bot commented Sep 11, 2023

pecanoro commented Sep 11, 2023

flaviadefaria commented Sep 11, 2023

parasharrajat commented Sep 11, 2023

narefyev91 commented Sep 12, 2023

pecanoro commented Sep 14, 2023

flaviadefaria commented Sep 14, 2023

flaviadefaria commented Sep 14, 2023

[HOLD for payment 2023-09-04] [$1000] Web - Money request - Copy to clipboard button does not copy content of an IOU edit comment #24569

[HOLD for payment 2023-09-04] [$1000] Web - Money request - Copy to clipboard button does not copy content of an IOU edit comment #24569

Comments

izarutskaya commented Aug 15, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Aug 15, 2023

melvin-bot bot commented Aug 15, 2023

Bug0 Triage Checklist (Main S/O)

OSBotify commented Aug 15, 2023

melvin-bot bot commented Aug 15, 2023

hungvu193 commented Aug 15, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

dukenv0307 commented Aug 15, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

BhuvaneshPatil commented Aug 15, 2023

pecanoro commented Aug 15, 2023

mountiny commented Aug 15, 2023

dukenv0307 commented Aug 15, 2023

0xmiros commented Aug 15, 2023

mountiny commented Aug 15, 2023

pecanoro commented Aug 15, 2023

melvin-bot bot commented Aug 15, 2023

flaviadefaria commented Sep 5, 2023

narefyev91 commented Sep 5, 2023

parasharrajat commented Sep 6, 2023

hungvu193 commented Sep 7, 2023

parasharrajat commented Sep 7, 2023 • edited Loading

parasharrajat commented Sep 7, 2023 • edited Loading

parasharrajat commented Sep 7, 2023 • edited Loading

parasharrajat commented Sep 7, 2023 • edited Loading

0xmiros commented Sep 7, 2023

parasharrajat commented Sep 8, 2023

melvin-bot bot commented Sep 11, 2023

pecanoro commented Sep 11, 2023

flaviadefaria commented Sep 11, 2023

parasharrajat commented Sep 11, 2023

narefyev91 commented Sep 12, 2023

pecanoro commented Sep 14, 2023

flaviadefaria commented Sep 14, 2023

flaviadefaria commented Sep 14, 2023

izarutskaya commented Aug 15, 2023 •

edited by melvin-bot bot

Loading

hungvu193 commented Aug 15, 2023 •

edited

Loading

dukenv0307 commented Aug 15, 2023 •

edited

Loading

parasharrajat commented Sep 7, 2023 •

edited

Loading

parasharrajat commented Sep 7, 2023 •

edited

Loading

parasharrajat commented Sep 7, 2023 •

edited

Loading

parasharrajat commented Sep 7, 2023 •

edited

Loading