Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-10-13] [TS migration] Migrate 'PaymentUtils.js' lib to TypeScript #24889

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 11 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/libs/PaymentUtils.js 7
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 11, 2023
@Skalakid
Copy link
Contributor

Hey! I’m Michał from Software Mansion, an expert agency, and I’d like to work on this issue!

@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 2, 2023

Triggered auto assignment to @joelbettner, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@mananjadhav
Copy link
Collaborator

@joelbettner Can you assign this issue to me, so that it is easier to track the payout?

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 6, 2023
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'PaymentUtils.js' lib to TypeScript [HOLD for payment 2023-10-13] [TS migration] Migrate 'PaymentUtils.js' lib to TypeScript Oct 6, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 6, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 6, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 6, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.78-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@joelbettner
Copy link
Contributor

@mananjadhav sorry for getting around to this late. I assigned you.

@melvin-bot melvin-bot bot removed the Overdue label Oct 16, 2023
@joelbettner
Copy link
Contributor

@JmillsExpensify I'm not sure how I was the only one who got auto assigned to this issue...I'm not actually able to do the payments. I figured I'd tag you since I know that you are able to do payments.

@JmillsExpensify JmillsExpensify self-assigned this Oct 16, 2023
@JmillsExpensify
Copy link

Payment summary: $250 for PR review.

@mananjadhav Please request via NewDot.

@mananjadhav
Copy link
Collaborator

Thanks @JmillsExpensify. Requested the payment.

@JmillsExpensify
Copy link

$250 payment approved for @mananjadhav based on summary above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Task Typescript Migration
Projects
Development

No branches or pull requests

4 participants