Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-10-25] [TS migration] Migrate 'API.js' lib to TypeScript #24902

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 15 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Task Typescript Migration Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/libs/API.js 9
Issue OwnerCurrent Issue Owner: @kevinksullivan
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@blazejkustra
Copy link
Contributor

Hey! I’m Błażej Kustra from Software Mansion, an expert agency, and I’d like to work on this issue!

@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 27, 2023

Triggered auto assignment to @iwiznia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 3, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 18, 2023
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'API.js' lib to TypeScript [HOLD for payment 2023-10-25] [TS migration] Migrate 'API.js' lib to TypeScript Oct 18, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 18, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 18, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 18, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.86-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-25. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@mollfpr
Copy link
Contributor

mollfpr commented Oct 19, 2023

@iwiznia Could you help assign me to the issue? Thank you!

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 25, 2023
@roryabraham roryabraham added the NewFeature Something to build that is a new item. label Oct 26, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 26, 2023

@melvin-bot melvin-bot bot added the Weekly KSv2 label Oct 26, 2023
@melvin-bot melvin-bot bot removed the Daily KSv2 label Oct 26, 2023
@roryabraham
Copy link
Contributor

@kevinksullivan tagging you in to take care of the C+ payment

@melvin-bot melvin-bot bot added the Overdue label Nov 6, 2023
@kevinksullivan
Copy link
Contributor

@mollfpr offer sent, lmk when you accept

https://www.upwork.com/jobs/~014ebf737422ca7251

@melvin-bot melvin-bot bot removed the Overdue label Nov 7, 2023
@mollfpr
Copy link
Contributor

mollfpr commented Nov 7, 2023

@kevinksullivan I'll do the manual request in NewDot. Could you give the payment summary? Thank you!

@mollfpr
Copy link
Contributor

mollfpr commented Nov 8, 2023

Friendly bump @kevinksullivan

@kevinksullivan
Copy link
Contributor

Ah sorry @mollfpr , thanks for the bump.

@kevinksullivan
Copy link
Contributor

Payment summary:

@kevinksullivan
Copy link
Contributor

@JmillsExpensify over to you 👍

@JmillsExpensify
Copy link

$250 payment approved for @mollfpr based on comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Task Typescript Migration Weekly KSv2
Projects
Development

No branches or pull requests

6 participants