Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS migration] Migrate 'launchApp.js' test to TypeScript #25286

Closed
melvin-bot bot opened this issue Aug 17, 2023 · 15 comments
Closed

[TS migration] Migrate 'launchApp.js' test to TypeScript #25286

melvin-bot bot opened this issue Aug 17, 2023 · 15 comments
Assignees
Labels
Monthly KSv2 NewFeature Something to build that is a new item. Reviewing Has a PR in review Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
tests/e2e/utils/launchApp.js 2
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 11, 2023
Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot closed this as completed Nov 23, 2023
@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@melvin-bot melvin-bot bot closed this as completed Feb 5, 2024
Copy link
Author

melvin-bot bot commented Feb 5, 2024

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@mountiny mountiny added NewFeature Something to build that is a new item. and removed Not a priority labels Feb 8, 2024
Copy link
Author

melvin-bot bot commented Feb 8, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Monthly KSv2 labels Feb 8, 2024
@mountiny mountiny reopened this Feb 8, 2024
@kubabutkiewicz
Copy link
Contributor

Hi, I'm Jakub from Callstack - expert contributor group - and I would like to take a look at this issue.

@isabelastisser
Copy link
Contributor

Hey @kubabutkiewicz, can you please provide an update? Thanks!

@kubabutkiewicz
Copy link
Contributor

Hi @isabelastisser Waiting for the internal review , when it pass I will mark this as ready to review

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Feb 16, 2024
@isabelastisser isabelastisser added Daily KSv2 and removed Weekly KSv2 labels Feb 16, 2024
Copy link
Author

melvin-bot bot commented Feb 16, 2024

Triggered auto assignment to @aldo-expensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@aldo-expensify
Copy link
Contributor

Merged

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Feb 19, 2024
@isabelastisser
Copy link
Contributor

Hey @aldo-expensify, I see the PR merged last week. What's next here?

@aldo-expensify
Copy link
Contributor

I think @thesahindia reviewed in the C+ role, so that compensation is pending.

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Mar 18, 2024
Copy link
Author

melvin-bot bot commented Mar 18, 2024

This issue has not been updated in over 15 days. @kubabutkiewicz, @isabelastisser, @aldo-expensify eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@thesahindia
Copy link
Member

I have requested $250 on new dot. We can close this.

@isabelastisser
Copy link
Contributor

Payment summary:

@thesahindia $250 in NewDot - C+ review.

The payment is pending!

@JmillsExpensify
Copy link

$250 approved for @thesahindia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Monthly KSv2 NewFeature Something to build that is a new item. Reviewing Has a PR in review Task Typescript Migration
Projects
Development

No branches or pull requests

6 participants