[HOLD for payment 2023-09-11] [HOLD for payment 2023-09-08] [$1000] CTRL+K, CTRL+SHIFT+K and CTRL+K again closes everything

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Click CTRL+K, it should open search
3. Click CTRL+SHIFT+K, it should open new group search
4. Again click CTRL+K, it closes everything instead of opening search

Expected Result:

App should reopen search page when we again click CTRL+K after CTRL+K, CTRL+SHIFT+K

Actual Result:

App closes everything when we again click CTRL+K after CTRL+K, CTRL+SHIFT+K

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.55-3
Reproducible in staging?: y
**Reproducible in production?:**n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

CTRL.K.again.closes.everything.mp4

Recording.1483.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692434730707179

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e2284d0efa12310e
• Upwork Job ID: 1693613839544455168
• Last Price Increase: 2023-08-21
• Automatic offers:
• Ollyws | Reviewer | 26306881
• shubham1206agra | Contributor | 26306882
• dhanashree-sawant | Reporter | 26306883

[melvin-bot]

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @dangrous (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[pradeepmdk]

Proposal

Please re-state the problem that we are trying to solve in this issue.

CTRL+K, CTRL+SHIFT+K and CTRL+K again closes everything

What is the root cause of that problem?

App/src/libs/Navigation/linkTo.js

Lines 62 to 74 in 58dc0c9

	if (action.type === 'NAVIGATE') {
	// If this action is navigating to the report screen and the top most navigator is different from the one we want to navigate - PUSH
	if (action.payload.name === NAVIGATORS.CENTRAL_PANE_NAVIGATOR && getTopmostReportId(root.getState()) !== getTopmostReportId(state)) {
	action.type = 'PUSH';
	// If the type is UP, we deeplinked into one of the RHP flows and we want to replace the current screen with the previous one in the flow
	// and at the same time we want the back button to go to the page we were before the deeplink
	} else if (type === 'UP') {
	action.type = 'REPLACE';
	// If this action is navigating to the RightModalNavigator and the last route on the root navigator is not RightModalNavigator then push
	} else if (action.payload.name === NAVIGATORS.RIGHT_MODAL_NAVIGATOR && _.last(root.getState().routes).name !== NAVIGATORS.RIGHT_MODAL_NAVIGATOR) {
	action.type = 'PUSH';

here on the right side navigate present NewGroup_Root and Search_Root both are in different stack navigators once is first time opened it will use push to dispatch when second-time shortcut key pressed navigation will happen at the time state not updating so again pressed whatever in the state its closed.

What changes do you think we should make in order to solve the problem?

by using REPLACE we can update the state in the navigation.

return Navigation.navigate(ROUTES.SEARCH, CONST.NAVIGATION.TYPE.UP);
return Navigation.navigate(ROUTES.NEW_GROUP, CONST.NAVIGATION.TYPE.UP);

in up
action.type = 'REPLACE';
replace the route.

[ShogunFire]

I don't reproduce

2023-08-20.10-00-27.mp4

[pradeepmdk]

@ShogunFire I am not sure why you are not able to reproduce. but this is still there even though staging is able to reproduce and I checked in locally with the latest code.

Screen.Recording.2023-08-21.at.5.50.00.AM.mov

[dhanashree-sawant]

Yes still able to reproduce

[mountiny]

@pradeepmdk This is a deploy blocker, can you point to a change which introduced this behaviour? I dont see it in your proposal and without it its hard to judge as we want to know the root cause of why this is happening in staging but not in production

[pradeepmdk]

@mountiny I think this one I saw removed the replace https://github.com/Expensify/App/pull/22355/files

[shubham1206agra]

@mountiny Please revert #24165
Reverting changes fixes the behaviour
Should I open a PR to revert this?

[shubham1206agra]

@mountiny Please revert #24165 Reverting changes fixes the behaviour Should I open a PR to revert this?

Meanwhile, I am investigating the problem with the current code.

[mountiny]

I have created a revert here #25572 could we make sure this bug is not repro there?

[shubham1206agra]

Here is the recording

Screen.Recording.2023-08-21.at.4.28.17.PM.mov

[aimane-chnaif]

I have created a revert here #25572 could we make sure this bug is not repro there?

Can you please generate build on the revert PR? I will confirm that bug is not repro there.

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @shubham1206agra got assigned: 2023-08-24 15:26:12 Z
• when the PR got merged: 2023-09-01 12:51:22 UTC
• days elapsed: 5

On to the next one 🚀

[shubham1206agra]

@mountiny Will I get urgency bonus for this PR?

[mountiny]

I think we can give th ebonus as the delay was not your fault

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.61-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fixing the race condition on history.go due to buggy queue async callbacks #25989

If no regressions arise, payment will be issued on 2023-09-08. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Ollyws requires payment offer (Reviewer)
• @shubham1206agra requires payment offer (Contributor)
• @dhanashree-sawant requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
• [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Ollyws] Determine if we should create a regression test for this bug.
• [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@tjferriss] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.62-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fixing the race condition on history.go due to buggy queue async callbacks #25989

If no regressions arise, payment will be issued on 2023-09-11. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Ollyws requires payment offer (Reviewer)
• @shubham1206agra requires payment offer (Contributor)
• @dhanashree-sawant requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
• [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Ollyws] Determine if we should create a regression test for this bug.
• [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@tjferriss] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[tjferriss]

@Ollyws I think you still need to accept the offer in Upworks. Can you also get started on the checklist?

@shubham1206agra and @dhanashree-sawant payments have been sent.

[shubham1206agra]

I think we can give th ebonus as the delay was not your fault

@tjferriss Can you confirm about bonus here?

[shubham1206agra]

@tjferriss Can you confirm this?

[tjferriss]

Confirmed, yes. I've updated both of your payments to include the bonus amount.

Payment summary:

• @Ollyws Reviewer $1500
• @shubham1206agra Contributor $1500
• @dhanashree-sawant Reporter $250

[tjferriss]

@Ollyws can you get started on the checklist so we can close the issue?

[Ollyws]

While this behaviour started in #24165 the root cause was a known bug in react-navigation, which we patched. So I don't think the checklist is really helpful here, let me know if you think otherwise.

[tjferriss]

Thanks for the detail. I think we're all good here.