[HOLD for payment 2023-09-04] Chat - New message overlaps edited tag to a quote

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to http://staging.new.expensify.com/
   and log in
2. Open any chat
3. Send a quote
4. Send a new message
5. Edit the quote

Expected Result:

There is enough space between the new message and the "Edited" tag

Actual Result:

The new message overlaps the "Edited" tag

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• Windows / Chrome
• MacOS / Desktop

Version Number: 1.3.56-2

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6173023_Recording__181.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @dangrous (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[daordonez11]

Proposal

Please re-state the problem that we are trying to solve in this issue.

edited message is overlapping with the next message in the chat if a quote is used

What is the root cause of that problem?

Due to this PR in BaseHTMLEngineProvider defaultViewProps now have styles.w100, styles.h100 which are causing the issue of the blockquote element specifically height 100%

What changes do you think we should make in order to solve the problem?

I think there might be more issues since this is used by the RenderHTMLSource but this is the first visible so there are two ways of solving it:

1. remove from defaultViewProps h100 and w100 and include it in the specific element required using webViewStyles.tagStyles
2. In the webViewStyles.tagStyles.blockquote element we can override height to avoid the issue.

I'm inclined to using solution 1 but it would require help from the author of the display receipts in chat to avoid any side effect in the implementation.

What alternative solutions did you explore? (Optional)

cc @Li357 @mountiny This is fixed with #25691

Sorry posted in wrong issue

[dangrous]

This is confirmed to be fixed on staging, I'm going to close it out.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.57-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Remove global styling in BaseHTMLEngineProvider #25691

If no regressions arise, payment will be issued on 2023-09-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty