[$500] [HOLD for payment 2023-09-04] App crashes when reciever clicking on an edited money request

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Log in to User A's account.
2. Open User B's chat.
3. Navigate to the "Request money" section.
4. Enter an amount and request it.
5. Click on the requested money for more details.
6. Click on the description and make edits.
7. Open another browser and log in with User B's account.
8. Open User A's chat and click on the requested money.

Expected Result:

The app should not crash when clicking on a money request

Actual Result:

The app sometimes crashes when clicking on an edited money request

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.56-20
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-recording-2023-08-22-at-73950-pm_RINHWOoS.1.mp4

Recording.1496.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692715648838749

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0191301f942c66eea9
• Upwork Job ID: 1699462033500999680
• Last Price Increase: 2023-09-06

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @hayata-suenaga (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[marcaaron]

I'm trying to repro this, but it's not happening for me.

Unless there is a consistent reproduction maybe we should demote it?

What account are we using to make these requests? With the email address associated with it we can check server logs to see if there's more information to go off of.

[marcaaron]

@aldo-expensify any luck in reproducing this?

[aldo-expensify]

Reproduced in staging, but I'm failing on dev

[aldo-expensify]

[marcaaron]

Are you testing on dev with the staging branch or main?

[aldo-expensify]

Are you testing on dev with the staging branch or main?

main branch

I reproduced in staging using with expensifail accounts, I had the account B already logged in when I created the money request. My steps:

1. Login both accounts in different browser sessions
2. Request money with account A without setting a description
3. Modify the description
4. With account B, click the IOU report in the LHN -> crash

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.57-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Stop showing receipt images for cash requests #25800

If no regressions arise, payment will be issued on 2023-09-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @ayazhussain79 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@puneetlath / @luacmartins / @marcaaron / @mountiny / @aldo-expensify] The PR that introduced the bug has been identified. Link to the PR:
• [@puneetlath / @luacmartins / @marcaaron / @mountiny / @aldo-expensify] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@puneetlath / @luacmartins / @marcaaron / @mountiny / @aldo-expensify] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@puneetlath / @luacmartins / @marcaaron / @mountiny / @aldo-expensify] Determine if we should create a regression test for this bug.
• [@puneetlath / @luacmartins / @marcaaron / @mountiny / @aldo-expensify] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0191301f942c66eea9

[melvin-bot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[puneetlath]

Just marked External to generate the Upwork job.

Looks like we just need to pay @ayazhussain79 for the bug report here. @ayazhussain79 can you please apply to it?

Anyone else, let me know if I missed you!

[ayazhussain79]

@puneetlath Applied on upwork

[puneetlath]

Offer sent!

[ayazhussain79]

Offer accepted. Thank you!

[puneetlath]

Paid. Thanks everyone.