-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-09-06] Adhoc builds do not always apply new patch #25863
Comments
Triggered auto assignment to @kevinksullivan ( |
Bug0 Triage Checklist (Main S/O)
|
commenting |
Looks like I don't need to be on here, but let me know if that changes! |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.58-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-09-06. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@mountiny, @adamgrzybowski Eep! 4 days overdue now. Issues have feelings too... |
This can be closed now I believe, handled with agency |
Problem
As @adamgrzybowski found when testing this PR #22437, when there is no change to the
package-lock.json
the adhoc build process uses cachecnode_modules
which means the new patch is not applied.This causes the build to be incorrect, missing the fix we want to test.
### Solution
Update the build script of the adhoc builds to check for changes in patches as well and in such case, make sure to apply them
The text was updated successfully, but these errors were encountered: