[HOLD for payment 2023-10-13] Chat - Chat history not loading after returning from offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Start staging.new.expensify.com or Expensify App
2. Log into any account that has chats with a long history
3. Open this chat
4. Go Offline
5. Scroll through cached chat history
6. Go online without leaving the chat

Expected Result:

Chat history should load after going online

Actual Result:

Chat history not loading after returning from offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• Windows / Chrome
• MacOS / Desktop

Version Number: 1.3.58-0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Chat-History-not-load-after-offline.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[luacmartins]

I can reproduce this issue. However, it seems to have the same root cause as #26181 where the ReconnectApp format is incorrect for ReportActions.

[luacmartins]

FWIW that's an issue in the API and is not a blocker for App deploy.

[luacmartins]

I'm gonna close this issue in favor of #26181

[chiragsalian]

Resolved on staging with a web-E CP. Closing issue. If it persists feel free to reopen.

[lanitochka17]

Issue reproducible on Build 1.3.63-0
OnePlus 9 PRO/Android 13.1

Record_2023-09-05-08-17-34.mp4

[luacmartins]

I think we can move this to a daily

[luacmartins]

@lanitochka17 can you still reproduce this issue? It doesn't seem to be that widespread

[lanitochka17]

@luacmartins Issue is still reproduce on latest build 1.3.67-1

bfv.mp4

[marcaaron]

@luacmartins gonna jump off this one since it seems like you've got more context on the issue than me at this point, but lmk if you need anything here.

[luacmartins]

Ok, I took a look at this and the problem isL

1. ReadOldestAction fails
2. We call SaveResponseInOnyx but response is undefined
3. We return early here and never process failureData.
4. Which means isLoadingMoreReportActions is never set to false here
5. And we never call ReadOldestAction again, because we return early here

[melvin-bot]

@luacmartins Eep! 4 days overdue now. Issues have feelings too...

[luacmartins]

Discussing solutions in the PR

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.78-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Apply Onyx failureData on fetch failure #27650

If no regressions arise, payment will be issued on 2023-10-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[luacmartins]

Adding Bug label to process payment for PR review - #27650

[adelekennedy]

@luacmartins confirm the below is correct?

Payouts due:

PR review Contributor+: $500 @situchan (Upwork)

Eligible for 50% #urgency bonus? N

Upwork

[luacmartins]

@adelekennedy yes, that's correct!

[adelekennedy]

Sent offer

[adelekennedy]

payment made!