Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LHN - Transaction thread changes to [Deleted message] after reloading #26191

Closed
1 of 6 tasks
izarutskaya opened this issue Aug 29, 2023 · 20 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@izarutskaya
Copy link

izarutskaya commented Aug 29, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Send a money request from account A to account B
  2. Open the transaction thread and click on the amount
  3. Change the amount
  4. Go back twice or open the chat page
  5. Reload the page
  6. Observe the transaction thread on LHN

Expected Result:

Transaction thread should not turn to a [Deleted message]

Actual Result:

Transaction thread changes to [Deleted message] upon reloading the page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: v1.3.58-1

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

2023-08-29.11.58.25.mp4
Recording.1356.mp4

Expensify/Expensify Issue URL:

Issue reported by: @Nathan-Mulugeta

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693299858979649

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018ab5c075ccb14fca
  • Upwork Job ID: 1696634543518457856
  • Last Price Increase: 2023-08-29
@izarutskaya izarutskaya added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 29, 2023

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Aug 29, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@izarutskaya izarutskaya added the DeployBlockerCash This issue or pull request should block deployment label Aug 29, 2023
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Aug 29, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Aug 29, 2023

Triggered auto assignment to @dangrous (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@dangrous
Copy link
Contributor

Looking into this. Based on how it's presenting, it's something to do with it handling the response from the server. I'm hoping it's still a FE issue and not something on the backend?

@dangrous
Copy link
Contributor

I'm pretty sure it's something to do with

function getReportName(report, policy = undefined) {
- if it gets to the bottom of that function it'll return [Deleted message] and that's the only place we use that that it makes sense to affect this. But, that function hasn't been changed recently so it must be something about where it's called or one of the helper functions. Stay tuned.

I also can't replicate this on dev which is not helpful, I'm trying to figure that out too.

@joekaufmanexpensify
Copy link
Contributor

I just checked and I can reproduce on staging only.

@dangrous
Copy link
Contributor

I have a (probably bad) hunch that it might be something to do with https://github.com/Expensify/Web-Expensify/pull/38626 and it not finding the right message/info for the parent report. But as that gets investigated hopefully we'll get some answers!

@luacmartins
Copy link
Contributor

@dangrous I agree that the root cause seems to come from https://github.com/Expensify/Web-Expensify/pull/38626

@luacmartins
Copy link
Contributor

Fix here - https://github.com/Expensify/Web-Expensify/pull/38665. The fix is in Web-E, so gonna remove the blocker label

@luacmartins luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Aug 29, 2023
@chiragsalian
Copy link
Contributor

Resolved on staging with a web-E CP. Closing issue. If it persists feel free to reopen.

@Nathan-Mulugeta
Copy link

Hey guys payment for issue reporter has not been processed

@joekaufmanexpensify
Copy link
Contributor

Good call, sorry about that @Nathan-Mulugeta !

@joekaufmanexpensify joekaufmanexpensify added the Internal Requires API changes or must be handled by Expensify staff label Aug 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 29, 2023

Job added to Upwork: https://www.upwork.com/jobs/~018ab5c075ccb14fca

@joekaufmanexpensify joekaufmanexpensify added Daily KSv2 and removed Hourly KSv2 labels Aug 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 29, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @ntdiary (Internal)

@joekaufmanexpensify
Copy link
Contributor

@Nathan-Mulugeta offer sent for $250!

@Nathan-Mulugeta
Copy link

Great, I just accepted the offer.

@joekaufmanexpensify
Copy link
Contributor

@Nathan-Mulugeta $250 sent and contract ended!

@joekaufmanexpensify
Copy link
Contributor

Upwork job closed.

@joekaufmanexpensify
Copy link
Contributor

All set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

8 participants