-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LHN - Transaction thread changes to [Deleted message] after reloading #26191
Comments
Triggered auto assignment to @joekaufmanexpensify ( |
Bug0 Triage Checklist (Main S/O)
|
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @dangrous ( |
Looking into this. Based on how it's presenting, it's something to do with it handling the response from the server. I'm hoping it's still a FE issue and not something on the backend? |
I'm pretty sure it's something to do with Line 1558 in 3f9f1e6
[Deleted message] and that's the only place we use that that it makes sense to affect this. But, that function hasn't been changed recently so it must be something about where it's called or one of the helper functions. Stay tuned.
I also can't replicate this on dev which is not helpful, I'm trying to figure that out too. |
I just checked and I can reproduce on staging only. |
I have a (probably bad) hunch that it might be something to do with https://github.com/Expensify/Web-Expensify/pull/38626 and it not finding the right message/info for the parent report. But as that gets investigated hopefully we'll get some answers! |
@dangrous I agree that the root cause seems to come from https://github.com/Expensify/Web-Expensify/pull/38626 |
Fix here - https://github.com/Expensify/Web-Expensify/pull/38665. The fix is in Web-E, so gonna remove the blocker label |
Resolved on staging with a web-E CP. Closing issue. If it persists feel free to reopen. |
Hey guys payment for issue reporter has not been processed |
Good call, sorry about that @Nathan-Mulugeta ! |
Job added to Upwork: https://www.upwork.com/jobs/~018ab5c075ccb14fca |
Triggered auto assignment to Contributor Plus for review of internal employee PR - @ntdiary ( |
@Nathan-Mulugeta offer sent for $250! |
Great, I just accepted the offer. |
@Nathan-Mulugeta $250 sent and contract ended! |
Upwork job closed. |
All set! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Transaction thread should not turn to a [Deleted message]
Actual Result:
Transaction thread changes to [Deleted message] upon reloading the page
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: v1.3.58-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
2023-08-29.11.58.25.mp4
Recording.1356.mp4
Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693299858979649
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: