Deprecate Paypal.me in product now that we're launching in-app payments and have settle-up elsewhere

[JmillsExpensify]

We're wasting a lot of time and money fixing Paypal related bugs, this just isn't worth it. It's also not a "real" feature so let's just deprecate it and focus on the stuff that matters.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01406c39bc77fa5134
• Upwork Job ID: 1699990475947565056
• Last Price Increase: 2023-09-08

[b4s36t4]

Deprecate in the sense? remove the option fully in frontend?

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Deprecate Paypal.me in product now that we're launching in-app payments and have settle-up elsewhere

What is the root cause of that problem?

Feature Request

What changes do you think we should make in order to solve the problem?

• Remove AddPayPalMePage.js page from here.

• Remove Paypal paymentMethod from SettlementButton.js:

  App/src/components/SettlementButton.js

  Line 99 in c20c387

  const paymentMethods = {

• Remove shouldShowPaypal menuItem from AddPaymentMethodMenu.js:

  App/src/components/AddPaymentMethodMenu.js

  Lines 76 to 84 in c20c387

  	...(props.shouldShowPaypal && !props.payPalMeData.description
  	? [
  	{
  	text: props.translate('common.payPalMe'),
  	icon: Expensicons.PayPal,
  	onSelected: () => props.onItemSelected(CONST.PAYMENT_METHODS.PAYPAL),
  	},
  	]
  	: []),

• Remove payPalMeData from PaymentMethodList.js:

  App/src/pages/settings/Wallet/PaymentMethodList.js

  Lines 31 to 32 in c20c387

  	/** Account details for PayPal.Me */
  	payPalMeData: paypalMeDataPropTypes,

  
  Also remove onyxKey from withOnyx HOC:

  App/src/pages/settings/Wallet/PaymentMethodList.js

  Lines 277 to 279 in c20c387

  	payPalMeData: {
  	key: ONYXKEYS.PAYPAL,
  	},

• Remove the add-paypal-me route:

  App/src/ROUTES.js

  Line 46 in c20c387

  SETTINGS_ADD_PAYPAL_ME: 'settings/wallet/add-paypal-me',

• Remove the shouldShowPaypal logic from MoneyReportHeader.js:

  App/src/components/MoneyReportHeader.js

  Line 82 in c20c387

  const shouldShowPaypal = Boolean(lodashGet(personalDetails, [moneyRequestReport.managerID, 'payPalMeAddress']));

• Remove settledMessage for paypal from MoneyRequestPreview.js:

  App/src/components/ReportActionItem/MoneyRequestPreview.js

  Lines 164 to 165 in c20c387

  	case CONST.IOU.PAYMENT_TYPE.PAYPAL_ME:
  	return props.translate('iou.settledPaypalMe');

• Add Deprecated to function definitions handling paypal

  • in IOU.js:

    App/src/libs/actions/IOU.js

    Line 1283 in c20c387

    function buildPayPalPaymentUrl(amount, submitterPayPalMeAddress, currency) {

  • in User.js:

    App/src/libs/actions/User.js

    Line 501 in c20c387

    function deletePaypalMeAddress() {

  • in ValidationUtils.js:

    App/src/libs/ValidationUtils.js

    Line 198 in c20c387

    function isValidPaypalUsername(paypalUsername) {

  • in PaymentUtils.js:

    App/src/libs/PaymentUtils.js

    Line 33 in c20c387

    function getPaymentMethodDescription(accountType, account) {

  • in PaymentMethods.js:

    App/src/libs/actions/PaymentMethods.js

    Lines 14 to 17 in c20c387

    	function deletePayPalMe() {
    	User.deletePaypalMeAddress();
    	Growl.show(Localize.translateLocal('walletPage.deletePayPalSuccess'), CONST.GROWL.SUCCESS, 3000);
    	}

What alternative solutions did you explore? (Optional)

xx

[JmillsExpensify]

Yes, sorry about that. I actually created this so we don't forget, as it's linked to an internal initiative. I'll put it on HOLD on now, though yes, I meant remove the remove the option and related code from the front-end.

[mountiny]

happy to help clear this up

[JmillsExpensify]

Alright, I posted internally on this issue and we agree to move forward with this. I'm removing the hold. We'll keep it internal.

[JmillsExpensify]

Noting the places that Paypal.me needs to be removed:

• Settings > Wallet > Add payment method > Paypal.me
• Bank accounts
• System messages
• Pay button on reports

And so on. Basically let's remove it everywhere it's referenced in the code and get this cleaned up.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01406c39bc77fa5134

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @burczu (Internal)

[melvin-bot]

@JmillsExpensify, @burczu, @mountiny Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[burczu]

@JmillsExpensify As this is internal, can I un-assign myself from this issue?

[mountiny]

@burczu we will still need your help reviewing and testing the PR, will be coming later this week

[mountiny]

Made a draft PR

[JmillsExpensify]

We should wrap this one up when you're back next week.

[mountiny]

Did not get around last week, I think i should be able to look into this in next couple of days

[mountiny]

was focusing on urgent tasks given limited time and easter

[mountiny]

struggled to prioritize this over more urgent tasks, in my backlog still

[JmillsExpensify]

Wow, blast from the past. I do think it'd be good to get this one done once and for all, time permitting.

[mountiny]

All in the App is covered so we just need the web and auth.

Started drafts on this, want to avoid breaking anything related to oldDot as there was some usage of Paypal too there.

[mountiny]

When travelling I have completed the Web and Auth PRs, I will clean them up and get them reviewed

[mountiny]

Web PR is in a review

[JmillsExpensify]

Nice work. Let's get this issue closed!

[mountiny]

web is merged, but not yet in production, Auth is waiting for the merge freeze to be lifted

[mountiny]

I have resolved merge conflicts on the auth PR, this might be more riskier change so might be fine to wait couple days

[mountiny]

Now that Auth perf is slightly better, I have cleaned up the tests and last PR is ready for final review and merge. Maxence is on it

[JmillsExpensify]

Still in the docket, looks like

[mountiny]

No, this is done 🎉