[HOLD for payment 2023-09-15] HIGH: Request money - Unable to open a scanned receipt

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #26155

Action Performed:

1. Open the app
2. Log into expensifail account
3. Navigate to a workspace chat
4. Tap "+" and select "Request money" > "Scan"
5. Scan a receipt and submit a request
6. Open the request in the chat and tap the scanned receipt image

Expected Result:

The scanned receipt is opened

Actual Result:

Unable to open the scanned receipt. It prevents from complete smart scanning

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.62-1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6186470_video_2023-09-02_14-22-55.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017e42c0a134392bbf
• Upwork Job ID: 1698776079310393344
• Last Price Increase: 2023-09-04

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We can't open the receipt image.

What is the root cause of that problem?

The receipt image is rendered by ReportActionItemImage. Currently, we can click the image only if the image has a thumbnail. If the thumbnail is null, we just render an image without pressable.

App/src/components/ReportActionItem/ReportActionItemImage.js

Lines 39 to 78 in 52b1e3e

	if (thumbnail) {
	const imageSource = tryResolveUrlFromApiRoot(image);
	const thumbnailSource = tryResolveUrlFromApiRoot(thumbnail);
	const thumbnailComponent = (
	<ThumbnailImage
	previewSourceURL={thumbnailSource}
	style={[styles.w100, styles.h100]}
	isAuthTokenRequired
	shouldDynamicallyResize={false}
	/>
	);
	if (enablePreviewModal) {
	return (
	<ShowContextMenuContext.Consumer>
	{({report}) => (
	<PressableWithoutFocus
	style={[styles.noOutline, styles.w100, styles.h100]}
	onPress={() => {
	const route = ROUTES.getReportAttachmentRoute(report.reportID, imageSource);
	Navigation.navigate(route);
	}}
	accessibilityRole={CONST.ACCESSIBILITY_ROLE.IMAGEBUTTON}
	accessibilityLabel={translate('accessibilityHints.viewAttachment')}
	>
	{thumbnailComponent}
	</PressableWithoutFocus>
	)}
	</ShowContextMenuContext.Consumer>
	);
	}
	return thumbnailComponent;
	}
	return (
	<Image
	source={{uri: image}}
	style={[styles.w100, styles.h100]}
	/>
	);

When we do a request with a receipt, the initial value of thumbnail is null.

App/src/libs/ReceiptUtils.js

Lines 43 to 46 in 52b1e3e

	// For local files, we won't have a thumbnail yet
	if (isReceiptImage && (path.startsWith('blob:') || path.startsWith('file:'))) {
	return {thumbnail: null, image: path};
	}

The BE will then return a URL to the thumbnail. So, if we test it while offline, we won't be able to click it no matter how long we wait.

What changes do you think we should make in order to solve the problem?

Wrap the Image with pressable too if enablePreviewModal is true.

here is how the code would look

const imageSource = tryResolveUrlFromApiRoot(image);

let children;
if (thumbnail) {
    const thumbnailSource = tryResolveUrlFromApiRoot(thumbnail);
    children = (
        <ThumbnailImage
            previewSourceURL={thumbnailSource}
            style={[styles.w100, styles.h100]}
            isAuthTokenRequired
            shouldDynamicallyResize={false}
        />
    );
} else {
    children = (
        <Image
            source={{uri: image}}
            style={[styles.w100, styles.h100]}
        />
    );
}

return !enablePreviewModal ? (
    children
) : (
    <ShowContextMenuContext.Consumer>
        {({report}) => (
            <PressableWithoutFocus
                style={[styles.noOutline, styles.w100, styles.h100]}
                onPress={() => {
                    const route = ROUTES.getReportAttachmentRoute(report.reportID, imageSource);
                    Navigation.navigate(route);
                }}
                accessibilityRole={CONST.ACCESSIBILITY_ROLE.IMAGEBUTTON}
                accessibilityLabel={translate('accessibilityHints.viewAttachment')}
            >
                {children}
            </PressableWithoutFocus>
        )}
    </ShowContextMenuContext.Consumer>
);

[mountiny]

confirming in slack if this is an actual issue to solve now

[mountiny]

Adding this to the high bucket based on https://expensify.slack.com/archives/C057F53HR40/p1693766785919719

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017e42c0a134392bbf

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @Ollyws (Internal)

[dylanexpensify]

@luacmartins can you take this on?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.65-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix receipt image modal logic #26815

If no regressions arise, payment will be issued on 2023-09-15. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@luacmartins] The PR that introduced the bug has been identified. Link to the PR: Display receipts in chat #24235
• [@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Display receipts in chat #24235 (comment)
• [@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@luacmartins] Determine if we should create a regression test for this bug. No regression needed
• [@luacmartins] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[luacmartins]

BZ checklist is complete. I think we need to pay @situchan for the PR review though

[dylanexpensify]

Nice! Payment summary:

• Contributor+: @situchan $500

Upwork job! Please apply!

[dylanexpensify]

@situchan bump on the above! 🙇‍♂️

[situchan]

Accepted invite. Thanks

[dylanexpensify]

offer sent @situchan!

[dylanexpensify]

done!