[$500] mWeb – Attachment - Unable to open image in new tab.

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in with any Gmail account
3. Open 1:1 conversation, click on the + button in the compose box
4. Tap on add attachment
5. Upload an image (jpeg or png)
6. Tap on Send
7. Tap on the image
8. Press and hold over the image

Expected Result:

The context menu opens and tap “Open image in new tab”. Verify the URL starts with "https://staging.new.expensify.com/chat-attachments/".

Actual Result:

Nothing happens. The context menu does not open. Unable to open image in new tab

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.72-6

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6207980_Unable_to_open_image_in_new_tab.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014bc07c9f376c4612
• Upwork Job ID: 1714382069331976192
• Last Price Increase: 2023-10-17

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[abdel-h66]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unable to open image in new tab on long pressing the attachment

What is the root cause of that problem?

The issue only happens on Chrome due to this line of code

App/src/components/Pressable/GenericPressable/BaseGenericPressable.js

Line 131 in 5aa7f6d

const defaultLongPressHandler = Browser.isMobileChrome() ? () => {} : undefined;

This passes an empty longPressHandler when the browser is chrome.
This line of code was added to fix an issue with the emojies being highlighted when long pressed. this is the issue
#24654 (comment)
And this is the PR fixing #26931

What changes do you think we should make in order to solve the problem?

The changes that I have made are basically avoid passing the empty handler in all cases and pass undefined instead to the Pressable
onLongPress={!isDisabled && onLongPress ? onLongPressHandler : undefined}

Being aware of the Emojies issue I also tested that to make sure it won't introduce a regression. and it didn't.

I believe @s-alves10 can have more information about that fix, and what could this proposal break, beside the emojies styling that I made sure it stayed behaving the same.

What alternative solutions did you explore? (Optional)

N/A

[s-alves10]

We're preventing default context menus. Is this worth fixing?

[abdel-h66]

Do you mean by passing the undefined we are preventing the default context menu ? Or that's the behavior that we are looking for ?

[melvin-bot]

@JmillsExpensify Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@JmillsExpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

@JmillsExpensify 10 days overdue. I'm getting more depressed than Marvin.

[melvin-bot]

@JmillsExpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@JmillsExpensify 12 days overdue now... This issue's end is nigh!

[melvin-bot]

This issue has not been updated in over 14 days. @JmillsExpensify eroding to Weekly issue.

[melvin-bot]

@JmillsExpensify this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[melvin-bot]

@JmillsExpensify Huh... This is 4 days overdue. Who can take care of this?

[JmillsExpensify]

Triaging for proposals.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014bc07c9f376c4612

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[melvin-bot]

@JmillsExpensify @0xmiroslav this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

• Decide whether any proposals currently meet our guidelines and can be approved as-is today
• If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot]

Current assignee @0xmiroslav is eligible for the Internal assigner, not assigning anyone new.

[melvin-bot]

@JmillsExpensify, @0xmiroslav Eep! 4 days overdue now. Issues have feelings too...

[0xmiros]

@abdel-h66 this is fixed already, right?

[abdel-h66]

Not sure, we need to double-check again.

[JmillsExpensify]

@applausebot Can we have someone re-test this issue to see if it's still outsanding?

[melvin-bot]

@JmillsExpensify, @0xmiroslav Eep! 4 days overdue now. Issues have feelings too...

[JmillsExpensify]

@lanitochka17 Are you able to re-test this one when you get a chance?

[melvin-bot]

@JmillsExpensify, @0xmiroslav Huh... This is 4 days overdue. Who can take care of this?

[JmillsExpensify]

In the queue for QA to re-test.

[bernhardoj]

This is already fixed in #28915

[melvin-bot]

@JmillsExpensify, @0xmiroslav Huh... This is 4 days overdue. Who can take care of this?

[0xmiros]

@JmillsExpensify let's close this

[greg-schroeder]

closing