[HOLD for payment 2023-10-17] Speedup getOrderedReportIDs by comparing strings instead of Dates objects

[mountiny]

Problem

For some reason creating Date object is super slow on Hermes. So @janicduplessis came up with the idea to compare strings instead. It will generate a different output but the error is only under 1s. The reason for that is that milliseconds representation can has different length.

Using this solution:

the method now runs under 1s instead of 14s (when starting heavy accounts

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

This issue has not been updated in over 15 days. @miljakljajic, @allroundexperts, @mountiny eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[mountiny]

This is ready for payment and its $500 to @allroundexperts for internal review and testing

[miljakljajic]

Payment summary: $500 to @allroundexperts for internal review and testing

@allroundexperts please request payment in newDot!

[JmillsExpensify]

$500 payment approved for @allroundexperts based on summary above.