Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS - SMS - Code is changed when select it in autofill #28494

Closed
1 of 6 tasks
lanitochka17 opened this issue Sep 29, 2023 · 9 comments
Closed
1 of 6 tasks

iOS - SMS - Code is changed when select it in autofill #28494

lanitochka17 opened this issue Sep 29, 2023 · 9 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Sep 29, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch App
  2. Enter SMS account
  3. Tap on the suggestion with the code received from messages

Expected Result:

Code fill out and sms account sign in

Actual Result:

Code is changed when select it in autofill

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.75-2

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6219107_1695996826355.RPReplay_Final1695939724.mp4

Bug6219107_1695996826378!3

Bug6219107_1695996826378!3 (1)

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 29, 2023

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Sep 29, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Sep 29, 2023

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@lanitochka17
Copy link
Author

Issue reproduced on build 1.3.75.3 on iPhone 14 Pro/ 17.0.2

RPReplay_Final1696009618.MP4

@situchan
Copy link
Contributor

I suspect this came from #24012 as it's only the recent change related to magic code input.

@wojtus7
Copy link
Contributor

wojtus7 commented Sep 30, 2023

Hi! I'am the creator of the Magic Code PR mentioned above and tried to repro the issue and fix it but my phone number doesn't seem to work. Do you know any workaround that would help me fix it?

image

@mountiny
Copy link
Contributor

mountiny commented Oct 1, 2023

@wojtus7 because this is a deploy blocker, should we consider reverting the PR given this is harder to test.

I think is the staging/ production backend env you just need to have real phone number

@melvin-bot melvin-bot bot added the Overdue label Oct 2, 2023
@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Oct 2, 2023
@melvin-bot melvin-bot bot removed the Overdue label Oct 2, 2023
@mountiny mountiny assigned mountiny and unassigned johnmlee101 Oct 2, 2023
@mountiny
Copy link
Contributor

mountiny commented Oct 2, 2023

@mountiny mountiny closed this as completed Oct 2, 2023
@wojtus7 wojtus7 mentioned this issue Oct 3, 2023
57 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review and removed Daily KSv2 labels Oct 3, 2023
@melvin-bot melvin-bot bot added the Weekly KSv2 label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants