[HOLD for payment 2023-11-07] Start migrating lists that are ready from FlatList to FlashList

[muttmuure]

Problem

While FlatList is suitable for typical use cases, our goal is to achieve the highest level of app performance, especially when dealing with extensive lists, such as Chats, Threads, Workspaces, Reports, and specific Money Threads.

Solution

To address this performance challenge, switch from FlatList to FlashList. By making this transition, we anticipate a significant performance improvement of approximately 2x.

Next Steps

Some lists are ready to migrate to FlashList, some are not (e.g. ChatList)

Here is a non-exhaustive list of lists that are ready for migration. If you find more, please feel free to add more!

LHNOptionsList
EmojiPickerMenu (web and native)
BaseAutoCompleteSuggestions
PaymentMethodList

Then let's work through the list of lists and get them migrated. Sound like a plan?

[adhorodyski]

Hi, I am Adam from Callstack, an expert contributor group. I’d like to work on this :)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.92-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• refactor(28902): [FlashList migration] PaymentMethodList #29095

If no regressions arise, payment will be issued on 2023-11-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @adhorodyski does not require payment (Contractor)

[roryabraham]

The PaymentList FlashList PR was reviewed by @burczu, so we'll be invoiced separately. Removing the HOLD for payment as we move forward with the other lists

[melvin-bot]

Triggered auto assignment to @dylanexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.93-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• chore: use optionRowHeight instead of paymentMethodHeight #30486

If no regressions arise, payment will be issued on 2023-11-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @adhorodyski does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@adhorodyski] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[dylanexpensify]

@roryabraham to confirm: any payments due here?

[roryabraham]

Nope

[roryabraham]

This has been split up so I'm closing it out