[$250] Request/split money description preview is not truncated

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.83-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @esh-g
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696863093475949

Action Performed:

1. Go to a chat with another person.
2. Click on request money.
3. Enter an amount.
4. Enter a very long description.
5. Go to the request preview

Expected Result:

The request preview should be truncated to include limited text

Actual Result:

The request preview is not truncated and can include a very big description

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Screen.Recording.2023-10-12.at.6.13.15.PM.mov

Android: mWeb Chrome

Screen.Recording.2023-10-12.at.6.15.36.PM.mov

iOS: Native

Screen.Recording.2023-10-12.at.6.14.41.PM.mov

iOS: mWeb Safari

RPReplay_Final1697114918.MP4

MacOS: Chrome / Safari

Screen.Recording.2023-10-09.at.8.19.12.PM.mov

Description.mp4

MacOS: Desktop

Screen.Recording.2023-10-12.at.6.12.08.PM.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a4eeb2d00d152256
• Upwork Job ID: 1712488709391478784
• Last Price Increase: 2024-03-06
• Automatic offers:
• situchan | Contributor | 27221035
• esh-g | Reporter | 27221037

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a4eeb2d00d152256

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[saranshbalyan-1234]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Request/split money description preview is not truncated

What is the root cause of that problem?

The root cause of the problem is that we have not passed numberOfLines prop to the Text element of description here.

App/src/components/ReportActionItem/MoneyRequestPreview.js

Line 318 in c0fe505

{shouldShowDescription && <Text style={[styles.colorMuted]}>{description}</Text>}

What changes do you think we should make in order to solve the problem?

We can pass on prop that is numberOfLines to whatever lines we would prefer. in most of the places in app it is 1, as this is description we can consider more as well.
Changes will be mage accordingly
The solution would look something like this

<Text style={[styles.colorMuted]} numberOfLines={1}>{description}</Text>

Result
https://github.com/Expensify/App/assets/57568571/2930df08-e2aa-41e4-9459-550d9d2c5efc

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[m-natarajan]

Proposal by @esh-g

Please re=state the problem

Request/split money description preview is not truncated

What is the root cause of the problem?

There is no logic to truncate the description preview in request/split money.

What changes should be made to fix this?

We should add the numberOfLines={3} attribute to the Text components for description as well as merchant in MoneyRequestPreview.js.

App/src/components/ReportActionItem/MoneyRequestPreview.js

Line 310 in d4b0a24

<Text style={[styles.textLabelSupporting, styles.mb1, styles.lh20, styles.breakWord]}>{requestMerchant}</Text>

App/src/components/ReportActionItem/MoneyRequestPreview.js

Line 318 in d4b0a24

{shouldShowDescription && <Text style={[styles.colorMuted]}>{description}</Text>}

setting the max lines to 3 is only a suggestion, but we can set it to any desirable number

[esh-g]

This is a bug as mentioned here: #28073 (comment), so we should work on this

[youssef-lr]

Closing in favor of #28073

[esh-g]

@youssef-lr could you please see the comment I linked above, it was decided as a separate bug there

[esh-g]

Bump @youssef-lr Please see that bugs are different

[youssef-lr]

Ah yes. So my PR which was merged has fixed the issue I linked. We'll need to fix the preview now right?

[situchan]

Right. Can I take over C+ here as I discussed with design team and have full context in #28073.

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @esh-g 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[zanyrenney]

Yes, that makes sense. I also see no comments or work from @mollfpr yet so this seems fair.

[zanyrenney]

seeing as you proactively asked to take this over @situchan please can you work on it with urgency and help review the proposals above? If none are suitable, please tell me so we can get more eyes on this.

[zanyrenney]

Hey everyone. After reviewing this with a buddy check from fellow BZ team member, we think we should be closing this.

• it is not s typical flow because the description being that long is not expected. there is no real life case we have seen with a description in that length
• the request doesn't fail- it's just not truncated, which feels like UI polish
• the fix from @youssef-lr solves any of the actual "technical" issues

Thanks!

[esh-g]

@zanyrenney I think if you look at this issue: #28073 (comment)
This was based on the fact of having a long description... Moreover, I think a long description is realistic if consider a case where a contract of the payment terms or work is sent.
@youssef-lr Would like your opinion on this as well

[esh-g]

gentle bump @zanyrenney @youssef-lr @situchan

[situchan]

This issue was raised based on @shawnborton's feedback - #28073 (comment)

[melvin-bot]

Upwork job price has been updated to $125

[youssef-lr]

Sounds good @esh-g @situchan. Adjusting price here as this is a simple fix.

[zanyrenney]

Thanks @youssef-lr !

[melvin-bot]

This issue has not been updated in over 15 days. @joelbettner, @zanyrenney, @esh-g, @situchan eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[esh-g]

I would once ask to reconsider the bounty on this one since it ended up taking a lot longer than expected mainly due to input delays... and it wasn't such a minor bug as expected...

[esh-g]

gentle bump @zanyrenney @situchan on the above ^

[zanyrenney]

@youssef-lr, please can you review as Joel has left, and I'd like an engineer's input. I'm assigning you to take a look, please!

[melvin-bot]

Upwork job price has been updated to $250

[youssef-lr]

Makes sense @esh-g, adjusted.

[zanyrenney]

thanks @youssef-lr ❤️

[zanyrenney]

payment summary
paid @esh-g - $250
paid @situchan $250