Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat - “Paste and Match Style”, “Paste as plain text”, Shift+Option+Cmd+V doesn't remove markdown #31805

Closed
2 of 6 tasks
kavimuru opened this issue Nov 23, 2023 · 9 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.3.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com or open Desktop App
  2. Login with any account
  3. Open any chat
  4. Copy message with markdown
  5. Paste it using “Paste and Match Style”, “Paste as plain text” for Desktop or Shift+Option+Cmd+V for Web

Expected Result:

Copied message pasted with markdown removed

Actual Result:

“Paste and Match Style”, “Paste as plain text”, Shift+Option+Cmd+V doesn't remove markdown

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6289021_1700780332583.Desktop-Paste-Match-Plain-not-Work.mp4

View all open jobs on GitHub

@kavimuru kavimuru added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 23, 2023
Copy link

melvin-bot bot commented Nov 23, 2023

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link

melvin-bot bot commented Nov 23, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Copy link

melvin-bot bot commented Nov 23, 2023

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@luacmartins
Copy link
Contributor

Probably coming from #31619

@goldendragon430
Copy link

Hi

@FitseTLT
Copy link
Contributor

Probably coming from #31619

Yeah, confirmed.
So @robertKozik @flodnv it looks like the simple fix of setting markdown on the plain text of the clipboard doesn't work so I have got two options:

  1. To make only PrivateNote (a module) handle code paste by sharing same code used in Compose.
  2. Make kind of TextInput module (or update the already exiting one) that handle code paste (html) that will be shared everywhere we use a text input that should have code paste feature.

@flodnv
Copy link
Contributor

flodnv commented Nov 24, 2023

Honestly I don't know what's best, maybe for now we just revert that PR

@luacmartins
Copy link
Contributor

Agreed. Revert PR here - #31852

@flodnv flodnv assigned flodnv and luacmartins and unassigned francoisl and twisterdotcom Nov 24, 2023
@melvin-bot melvin-bot bot added the Overdue label Nov 27, 2023
@luacmartins
Copy link
Contributor

We reverted this PR and the issue is no longer reproducible. Closing this issue in favor of the original one - #29806

@melvin-bot melvin-bot bot removed the Overdue label Nov 27, 2023
@luacmartins luacmartins added Overdue and removed DeployBlockerCash This issue or pull request should block deployment labels Nov 27, 2023
@melvin-bot melvin-bot bot removed the Overdue label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants