[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$500][Dupe Detection] Surfacing Potential Duplicates

[pecanoro]

Part of the project

Main issue: https://github.com/Expensify/Expensify/issues/307591
Doc section: Surfacing Potential Duplicates
Project: [Wave: Collect Approvers] Dupe Detection

UI

Feature Description

Update the comment type here since this can be a single string or a full array containing different transactions NVPs. In this case, it looks like this:

The HOLD doc implemented the logic to display the HOLD notification for each expense. You can see the details here. However, we need to make the following changes to update the HOLD notification in case it is duplicated.

• Add a new function called TransactionUtils.isDuplicate(transactionID, checkDismissed) that will check if there is an existing duplicate violation for the given transactionID and has been dismissed:

  • Listen to the transactionViolations_* Onyx key. Remember the key looks like this:
    

  • Check if the duplicatedTransaction key is set in the above Onyx key for the transaction and return true only if the following condition is not met:

    • Since the violation could have been dismissed, check if the corresponding transactions_* key contains an entry for the current user:
      

• Add a new condition to ReportUtils.isOnHold to see if the transaction is a duplicate by calling TransactionUtils.isDuplicate(transactionID, true).

• In components/ReportActionItem/MoneyRequestView.js in the View for the HOLD banner:

  • Check if the transaction has any duplicates by checking the corresponding Onyx key transactionViolations_*. If so, replace the props.translate('iou.requestOnHold') for props.translate('iou.requestDuplicate') that contains the message defined in the screenshot at the beginning of the issue (asked me for the Spanish translations).

  • If there are duplicates, add a new <Button> to review duplicates. Don't navigate anywhere for now but eventually it will do the following:

    • Navigate the user to the route for a new page ReviewDuplicate

    • Pass the threadReportID of the transaction in the route to the new page.

Manual Test Steps

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016dc734e5d5fc1a3f
• Upwork Job ID: 1778425579213647872
• Last Price Increase: 2024-04-11
• Automatic offers:
• akinwale | Reviewer | 0
• gijoe0295 | Contributor | 0

Issue Owner

Current Issue Owner: @MitchExpensify

[melvin-bot]

@pecanoro, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[pecanoro]

@MelvinBot Well Melvin, we are prioritizing this again, so reopening!

[melvin-bot]

Triggered auto assignment to @MitchExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[MitchExpensify]

Will this ultimately be internal or external @pecanoro ?

[pecanoro]

@MitchExpensify Ideally external, but I am trying to wrap up the back-end first.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016dc734e5d5fc1a3f

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

[melvin-bot]

This issue has not been updated in over 15 days. @akinwale, @pecanoro, @MitchExpensify, @gijoe0295 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• feat: surfacing potential duplicates #40153

If no regressions arise, payment will be issued on 2024-06-18. 🎊

For reference, here are some details about the assignees on this issue:

• @akinwale requires payment automatic offer (Reviewer)
• @gijoe0295 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@akinwale] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• feat: surfacing potential duplicates #40153

If no regressions arise, payment will be issued on 2024-06-20. 🎊

For reference, here are some details about the assignees on this issue:

• @akinwale requires payment automatic offer (Reviewer)
• @gijoe0295 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@akinwale] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[MitchExpensify]

Reminder set to pay, do we need BZ steps here @akinwale ?

[akinwale]

Reminder set to pay, do we need BZ steps here @akinwale ?

@MitchExpensify Yes, we do. I'll post them shortly. Also, please note the PR was initially deployed to production 2024-06-11, so the correct payment due date should be 2024-06-18.

[akinwale]

• [@akinwale] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.

Regression Test Steps
Prerequisites

• Control workspace with Expense Violations enabled
• Account is an employee member of Control workspace and violations are enabled for the account
• Use staging server on if testing on dev

1. Launch the Expensify app.
2. Login as a member of the Control workspace.
3. Submit 2 expenses with the same amount (avoiding limit violations), currency, merchant and date to the workspace.
4. Navigate to the workspace chat where the expense was created.
5. Open the expense report.
6. Verify that each expense preview has a red dot indicator and Cash · Duplicate · Hold at the top
7. Open any one of the transactions in the expense report.
8. Verify that the HOLD banner is displayed at the top.
9. Verify that the text, This expense has the same details as another one. Review the duplicates to remove the hold. is displayed.
10. Verify that a Review duplicates button is displayed. Clicking or tapping the button does nothing at the moment.

Do we agree 👍 or 👎?

[gijoe0295]

@MitchExpensify Ready for payment 👍

[MitchExpensify]

Paid and contracts ended!