[HOLD for payment 2024-01-04] Chat - Extra space before '(Until tomorrow)' in tooltip for status

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.13-6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Open the app
2. Open settings -> profile -> status
3. Select any emoji and without any message or change in clear after, save the status
4. Open any report in which you have sent message before or send a new message in it
5. Hover on status besides your username and observe that app displays extra space before '(Until tomorrow)' text in tooltip even though message field was kept empty

Expected Result:

App should display '(Until tomorrow)' in center in tooltip when status is saved with empty message

Actual Result:

App displays '(Until tomorrow)' slightly towards right due to extra space before the text in tooltip when status is saved with empty message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6317800_1702892201306.windows_chrome_-_extra_space_before_until_tomorrow.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to @lakchote (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - Extra space before '(Until tomorrow)' in tooltip for status

What is the root cause of that problem?

App/src/pages/home/report/ReportActionItemSingle.js

Line 209 in e9d05f8

const statusTooltipText = formattedDate ? `${statusText} (${formattedDate})` : statusText;

This happens when status.text is empty string. So statusTooltipText becomes ${statusText} (${formattedDate})

What changes do you think we should make in order to solve the problem?

If status.text is empty, no need to add space at the beginning
So change above line like this:

    const statusTooltipText = formattedDate ? `${statusText ? `${statusText} ` : ''}(${formattedDate})` : statusText;

Also apply same fix in LHN:

App/src/components/LHNOptionsList/OptionRowLHN.js

Line 154 in e9d05f8

const statusContent = formattedDate ? `${statusText} (${formattedDate})` : statusText;

[lakchote]

@mkhutornyi thanks for your proposal but given the simplicity of the fix, I've decided to make a PR.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.18-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix tooltip extra space when status text is empty #33332

If no regressions arise, payment will be issued on 2024-01-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@lakchote] The PR that introduced the bug has been identified. Link to the PR:
• [@lakchote] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@lakchote] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@lakchote] Determine if we should create a regression test for this bug.
• [@lakchote] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@NicMendonca] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[NicMendonca]

no payment required

[shubham1206agra]

@NicMendonca Can you recheck payment here? I have reviewed the PR linked to this issue.

[mkhutornyi]

Am I eligible for any payment for my solution being used? And helped reviewing PR.
cc: @lakchote

[NicMendonca]

@shubham1206agra sorry - you should have been assigned!

[NicMendonca]

@shubham1206agra I sent you an offer

[NicMendonca]

@mkhutornyi you are not eligible for payment here

[shubham1206agra]

Accepted

[NicMendonca]

paid!