[HOLD for payment 2024-02-15] [$500] New Distance Requests Should Default to the "Default Distance Category"

[yuwenmemon]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.14-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): yuwen@expensify.com
Logs: N/A
Expensify/Expensify Issue URL: N/A
Issue reported by: @yuwenmemon
Slack conversation: https://expensify.slack.com/archives/C05DWUDHVK7/p1702928915733459

Action Performed:

Break down in numbered steps

1. In the OldDot policy editor, navigate to Workspace -> Expenses -> Distance
2. Set a Default Distance Category:

1(a). Alternatively, if you done have access to your Workspace in OldDot, set a default category for the distance unit via JS on OldDot:

const p = Policy.getByID('<workspace ID>');
p.policy.customUnits[0].defaultCategory = 'Advertising'; // check the index though
p.save();

3. As a submitter, Navigate to the Workspace Chat in NewDot
4. Create a new distance request without an explicit category. Follow the steps all the way until the confirmation step:
   

Expected Result:

The distance request should have the default category filled in by default

Actual Result:

The category field is blank

Workaround:

The default category will be set in the back end via https://github.com/Expensify/Auth/pull/9488, but we should still have this set for users in the front-end so the setting does not come as a suprise.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Kapture.2023-12-20.at.16.03.24.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d091e9e76b7055e0
• Upwork Job ID: 1737625066164363264
• Last Price Increase: 2023-12-28

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d091e9e76b7055e0

[melvin-bot]

Triggered auto assignment to @peterdbarkerUK (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The category field is blank

What is the root cause of that problem?

This is new feature.

What changes do you think we should make in order to solve the problem?

When creating distance request in the confirmation step

• Look for defaultCategory in the policy.customUnits data (find the customUnit that has name Distance similar to in here, and get it's defaultCategory)
• Prefill the category field with defaultCategory by setting in Onyx IOU/transaction data, we can do that in an useEffect

What alternative solutions did you explore? (Optional)

We can do the above right when initiating the distance request transaction rather than when reaching confirmation list.

[melvin-bot]

@yuwenmemon, @peterdbarkerUK, @situchan Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@yuwenmemon, @peterdbarkerUK, @situchan 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@yuwenmemon, @peterdbarkerUK, @situchan 10 days overdue. Is anyone even seeing these? Hello?

[melvin-bot]

@yuwenmemon, @peterdbarkerUK, @situchan 10 days overdue. I'm getting more depressed than Marvin.

[peterdbarkerUK]

Not overdue, Yuwen was OoO for holidays

[melvin-bot]

❌ There was an error making the offer to @situchan for the Reviewer role. The BZ member will need to manually hire the contributor.

[melvin-bot]

❌ There was an error making the offer to @tienifr for the Contributor role. The BZ member will need to manually hire the contributor.

[yuwenmemon]

@tienifr's proposal looks good. @peterdbarkerUK can you resolve the issue above?

[melvin-bot]

@yuwenmemon @peterdbarkerUK @situchan @tienifr this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[tienifr]

PR ready for review #34012.

[situchan]

@dylanexpensify I asked question here before PR approval

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[dylanexpensify]

resolved query, let's get this merged!

[strepanier03]

Woohoo, thanks @dylanexpensify.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.38-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Set default category for distance request #34012

If no regressions arise, payment will be issued on 2024-02-15. 🎊

For reference, here are some details about the assignees on this issue:

• @situchan requires payment (Needs manual offer from BZ)
• @tienifr requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[strepanier03]

@situchan and @tienifr - I've sent you offers via Upwork, please accept when you can.

@situchan - I know we're a few days off from pay being released but I'll work on the reg test, if applicable, as soon as you post. Feel free to @ mention me when you do!

Chat again in a few days 👋

[situchan]

This is new feature

Regression Test Proposal

1. In OD policy editor, go to Workspace >> Expenses >> Distance
2. Set a Default Distance Category
3. Navigate to the workspace chat in ND
4. Create a new distance request without an explicit category, follow the steps until the confirmation screen
5. Verify that the category field is set with the default category from step 2

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @situchan paid $500 via Upwork
• ROLE: @tienifr paid $500 via Upwork

BugZero Checklist (@strepanier03)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1737625066164363264/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[strepanier03]

Everyone's paid and the reg test is pending, closing.